Page MenuHomePhabricator
Differential D13295

[lib] fetchLedFarcasterChannels method
ClosedPublic
Actions

Authored by varun on Sep 11 2024, 10:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 9, 10:13 AM
Unknown Object (File)
Feb 26 2025, 11:36 AM
Unknown Object (File)
Feb 15 2025, 9:28 PM
Unknown Object (File)
Feb 1 2025, 12:23 AM
Unknown Object (File)
Feb 1 2025, 12:23 AM
Unknown Object (File)
Feb 1 2025, 12:23 AM
Unknown Object (File)
Feb 1 2025, 12:23 AM
Unknown Object (File)
Jan 15 2025, 6:16 AM
View All 59 Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMM0773972d40c7: [lib] fetchLedFarcasterChannels method
Summary

similar to fetchFollowedFarcasterChannels, except we filter out channels that the user does not lead

Depends on D13293

Test Plan

https://gist.github.com/vdhanan/fdc48cf3a29f0394ec5646f7c728cefa

confirmed that the new method returned all the channels led by that user and that the existing method returned the same results as before

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Sep 11 2024, 10:58 AM
Herald added a subscriber: tomek. · View Herald TranscriptSep 11 2024, 10:58 AM
varun edited the test plan for this revision. (Show Details)Sep 11 2024, 10:59 AM
varun edited the test plan for this revision. (Show Details)
varun updated this revision to Diff 44054.Sep 11 2024, 11:09 AM

remove unnecessary async keyword

Harbormaster completed remote builds in B31541: Diff 44050.Sep 11 2024, 11:16 AM
Harbormaster completed remote builds in B31545: Diff 44054.Sep 11 2024, 11:28 AM
varun requested review of this revision.Sep 11 2024, 11:28 AM
ashoat accepted this revision.Sep 11 2024, 12:56 PM

Guessing there isn't a better Neynar API for this?

This revision is now accepted and ready to land.Sep 11 2024, 12:56 PM
varun added a comment.Sep 11 2024, 1:44 PM
In D13295#374730, @ashoat wrote:

Guessing there isn't a better Neynar API for this?

couldn't find a better one

varun added a child revision: D13300: [keyserver] update joinThread to automatically make farcaster channel lead a community admin.Sep 11 2024, 4:23 PM
varun removed a child revision: D13300: [keyserver] update joinThread to automatically make farcaster channel lead a community admin.Sep 11 2024, 4:33 PM
Closed by commit rCOMM0773972d40c7: [lib] fetchLedFarcasterChannels method (authored by varun). · Explain WhySep 11 2024, 4:38 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM0773972d40c7: [lib] fetchLedFarcasterChannels method.
varun added a child revision: D13300: [keyserver] update joinThread to automatically make farcaster channel lead a community admin.Sep 12 2024, 4:14 AM

Revision Contents
Changeset List

PathSize
lib/
types/
4 lines
utils/
7 lines

Diff 44066

View Options

lib/types/farcaster-types.js

Show All 12 Linesimport {
entryRevisionFetchResponder, entryRevisionFetchResponder,
entryCreationResponder, entryCreationResponder,
entryUpdateResponder, entryUpdateResponder,
entryDeletionResponder, entryDeletionResponder,
entryRestorationResponder, entryRestorationResponder,
calendarQueryUpdateResponder, calendarQueryUpdateResponder,
} from './responders/entry-responders.js'; } from './responders/entry-responders.js';
import type { JSONResponder } from './responders/handlers.js'; import type { JSONResponder } from './responders/handlers.js';
import { getSessionPublicKeysResponder } from './responders/keys-responders.js'; import {
getSessionPublicKeysResponder,
getOlmSessionInitializationDataResponder,
} from './responders/keys-responders.js';
import { inviteLinkVerificationResponder } from './responders/link-responders.js'; import { inviteLinkVerificationResponder } from './responders/link-responders.js';
import { messageReportCreationResponder } from './responders/message-report-responder.js'; import { messageReportCreationResponder } from './responders/message-report-responder.js';
import { import {
textMessageCreationResponder, textMessageCreationResponder,
messageFetchResponder, messageFetchResponder,
multimediaMessageCreationResponder, multimediaMessageCreationResponder,
reactionMessageCreationResponder, reactionMessageCreationResponder,
editMessageCreationResponder, editMessageCreationResponder,
▲ Show 20 Lines • Show All 239 Lines • ▼ Show 20 Linesconst jsonEndpoints: { [id: Endpoint]: JSONResponder } = {
update_user_avatar: { update_user_avatar: {
responder: updateUserAvatarResponder, responder: updateUserAvatarResponder,
requiredPolicies: baseLegalPolicies, requiredPolicies: baseLegalPolicies,
}, },
upload_media_metadata: { upload_media_metadata: {
responder: uploadMediaMetadataResponder, responder: uploadMediaMetadataResponder,
requiredPolicies: baseLegalPolicies, requiredPolicies: baseLegalPolicies,
}, },
get_olm_session_initialization_data: {
responder: getOlmSessionInitializationDataResponder,
requiredPolicies: [],
},
}; };
export { jsonEndpoints }; export { jsonEndpoints };
View Options

lib/utils/neynar-client.js

Show All 12 Linesimport {
entryRevisionFetchResponder, entryRevisionFetchResponder,
entryCreationResponder, entryCreationResponder,
entryUpdateResponder, entryUpdateResponder,
entryDeletionResponder, entryDeletionResponder,
entryRestorationResponder, entryRestorationResponder,
calendarQueryUpdateResponder, calendarQueryUpdateResponder,
} from './responders/entry-responders.js'; } from './responders/entry-responders.js';
import type { JSONResponder } from './responders/handlers.js'; import type { JSONResponder } from './responders/handlers.js';
import { getSessionPublicKeysResponder } from './responders/keys-responders.js'; import {
getSessionPublicKeysResponder,
getOlmSessionInitializationDataResponder,
} from './responders/keys-responders.js';
import { inviteLinkVerificationResponder } from './responders/link-responders.js'; import { inviteLinkVerificationResponder } from './responders/link-responders.js';
import { messageReportCreationResponder } from './responders/message-report-responder.js'; import { messageReportCreationResponder } from './responders/message-report-responder.js';
import { import {
textMessageCreationResponder, textMessageCreationResponder,
messageFetchResponder, messageFetchResponder,
multimediaMessageCreationResponder, multimediaMessageCreationResponder,
reactionMessageCreationResponder, reactionMessageCreationResponder,
editMessageCreationResponder, editMessageCreationResponder,
▲ Show 20 Lines • Show All 239 Lines • ▼ Show 20 Linesconst jsonEndpoints: { [id: Endpoint]: JSONResponder } = {
update_user_avatar: { update_user_avatar: {
responder: updateUserAvatarResponder, responder: updateUserAvatarResponder,
requiredPolicies: baseLegalPolicies, requiredPolicies: baseLegalPolicies,
}, },
upload_media_metadata: { upload_media_metadata: {
responder: uploadMediaMetadataResponder, responder: uploadMediaMetadataResponder,
requiredPolicies: baseLegalPolicies, requiredPolicies: baseLegalPolicies,
}, },
get_olm_session_initialization_data: {
responder: getOlmSessionInitializationDataResponder,
requiredPolicies: [],
},
}; };
export { jsonEndpoints }; export { jsonEndpoints };