Page MenuHomePhabricator
Differential D13303

Update input type of useSetThreadUnreadStatus
ClosedPublic
Actions

Authored by marcin on Sep 12 2024, 5:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 1, 6:21 PM
Unknown Object (File)
Tue, Apr 1, 1:45 PM
Unknown Object (File)
Tue, Apr 1, 8:22 AM
Unknown Object (File)
Tue, Apr 1, 4:27 AM
Unknown Object (File)
Mon, Mar 31, 5:32 PM
Unknown Object (File)
Mon, Mar 31, 3:12 AM
Unknown Object (File)
Wed, Mar 19, 8:25 AM
Unknown Object (File)
Mar 4 2025, 8:06 PM
View All 88 Files
Subscribers
ashoat

Details

Reviewers
tomek
kamil
Commits
rCOMM0f616c5a4e92: Update input type of useSetThreadUnreadStatus
Summary

This differential updates input type of useSetThreadunreadStatus

Test Plan

Check that manually updating threads as read/unread works for both thick and thin threads/

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-9171
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
actions/
28 lines
hooks/
22 lines

Diff 44076

View Options

lib/actions/activity-actions.js

use actix_web::{ use actix_web::{
error::{ error::{
ErrorBadRequest, ErrorConflict, ErrorInternalServerError, ErrorBadRequest, ErrorConflict, ErrorInternalServerError,
ErrorServiceUnavailable, HttpError, ErrorServiceUnavailable, HttpError,
}, },
HttpResponse, ResponseError, HttpResponse, ResponseError,
}; };
pub use aws_sdk_dynamodb::Error as DynamoDBError;
use comm_services_lib::blob::client::BlobServiceError; use comm_services_lib::blob::client::BlobServiceError;
use comm_services_lib::database::Error as DBError;
use reqwest::StatusCode; use reqwest::StatusCode;
use tracing::{error, trace, warn}; use tracing::{error, trace, warn};
#[derive( #[derive(
Debug, derive_more::Display, derive_more::From, derive_more::Error, Debug, derive_more::Display, derive_more::From, derive_more::Error,
)] )]
pub enum BackupError { pub enum BackupError {
BlobError(BlobServiceError), BlobError(BlobServiceError),
DB(comm_services_lib::database::Error),
} }
impl From<&BackupError> for actix_web::Error { impl From<&BackupError> for actix_web::Error {
fn from(value: &BackupError) -> Self { fn from(value: &BackupError) -> Self {
trace!("Handling backup service error: {value}"); trace!("Handling backup service error: {value}");
match value { match value {
BackupError::BlobError( BackupError::BlobError(
err @ (BlobServiceError::ClientError(_) err @ (BlobServiceError::ClientError(_)
Show All 10 Lines match value {
ErrorBadRequest("bad request") ErrorBadRequest("bad request")
} }
BackupError::BlobError( BackupError::BlobError(
err @ (BlobServiceError::URLError(_) | BlobServiceError::NotFound), err @ (BlobServiceError::URLError(_) | BlobServiceError::NotFound),
) => { ) => {
error!("Unexpected blob error: {err}"); error!("Unexpected blob error: {err}");
ErrorInternalServerError("server error") ErrorInternalServerError("server error")
} }
BackupError::DB(err) => match err {
DBError::AwsSdk(
err @ (DynamoDBError::InternalServerError(_)
| DynamoDBError::ProvisionedThroughputExceededException(_)
| DynamoDBError::RequestLimitExceeded(_)),
) => {
warn!("AWS transient error occurred: {err}");
ErrorServiceUnavailable("please retry")
}
unexpected => {
error!("Received an unexpected DB error: {0:?} - {0}", unexpected);
ErrorInternalServerError("server error")
}
},
} }
} }
} }
impl From<BackupError> for HttpError { impl From<BackupError> for HttpError {
fn from(value: BackupError) -> Self { fn from(value: BackupError) -> Self {
value.into() value.into()
} }
Show All 13 Lines
View Options

lib/hooks/toggle-unread-status.js

use actix_web::{ use actix_web::{
error::{ error::{
ErrorBadRequest, ErrorConflict, ErrorInternalServerError, ErrorBadRequest, ErrorConflict, ErrorInternalServerError,
ErrorServiceUnavailable, HttpError, ErrorServiceUnavailable, HttpError,
}, },
HttpResponse, ResponseError, HttpResponse, ResponseError,
}; };
pub use aws_sdk_dynamodb::Error as DynamoDBError;
use comm_services_lib::blob::client::BlobServiceError; use comm_services_lib::blob::client::BlobServiceError;
use comm_services_lib::database::Error as DBError;
use reqwest::StatusCode; use reqwest::StatusCode;
use tracing::{error, trace, warn}; use tracing::{error, trace, warn};
#[derive( #[derive(
Debug, derive_more::Display, derive_more::From, derive_more::Error, Debug, derive_more::Display, derive_more::From, derive_more::Error,
)] )]
pub enum BackupError { pub enum BackupError {
BlobError(BlobServiceError), BlobError(BlobServiceError),
DB(comm_services_lib::database::Error),
} }
impl From<&BackupError> for actix_web::Error { impl From<&BackupError> for actix_web::Error {
fn from(value: &BackupError) -> Self { fn from(value: &BackupError) -> Self {
trace!("Handling backup service error: {value}"); trace!("Handling backup service error: {value}");
match value { match value {
BackupError::BlobError( BackupError::BlobError(
err @ (BlobServiceError::ClientError(_) err @ (BlobServiceError::ClientError(_)
Show All 10 Lines match value {
ErrorBadRequest("bad request") ErrorBadRequest("bad request")
} }
BackupError::BlobError( BackupError::BlobError(
err @ (BlobServiceError::URLError(_) | BlobServiceError::NotFound), err @ (BlobServiceError::URLError(_) | BlobServiceError::NotFound),
) => { ) => {
error!("Unexpected blob error: {err}"); error!("Unexpected blob error: {err}");
ErrorInternalServerError("server error") ErrorInternalServerError("server error")
} }
BackupError::DB(err) => match err {
DBError::AwsSdk(
err @ (DynamoDBError::InternalServerError(_)
| DynamoDBError::ProvisionedThroughputExceededException(_)
| DynamoDBError::RequestLimitExceeded(_)),
) => {
warn!("AWS transient error occurred: {err}");
ErrorServiceUnavailable("please retry")
}
unexpected => {
error!("Received an unexpected DB error: {0:?} - {0}", unexpected);
ErrorInternalServerError("server error")
}
},
} }
} }
} }
impl From<BackupError> for HttpError { impl From<BackupError> for HttpError {
fn from(value: BackupError) -> Self { fn from(value: BackupError) -> Self {
value.into() value.into()
} }
Show All 13 Lines