Page MenuHomePhabricator
Differential D13420

[web] Fix multimedia sending conditions for thick threads
ClosedPublic
Actions

Authored by bartek on Sep 23 2024, 2:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 15, 2:42 PM
Unknown Object (File)
Sat, Mar 15, 5:30 AM
Unknown Object (File)
Fri, Mar 14, 4:10 AM
Unknown Object (File)
Wed, Mar 5, 5:39 PM
Unknown Object (File)
Wed, Mar 5, 9:22 AM
Unknown Object (File)
Wed, Mar 5, 9:22 AM
Unknown Object (File)
Wed, Mar 5, 9:22 AM
Unknown Object (File)
Wed, Mar 5, 9:21 AM
View All 57 Files
Subscribers
ashoat

Details

Reviewers
kamil
tomek
Commits
rCOMM1e6ec1abd465: [web] Fix multimedia sending conditions for thick threads
Summary

Implements 2c from ENG-9345.
Details in the Linear comment.

Depends on D13419

Test Plan

Successfully sent a photo:

  • "quickly" (before upload finished) and "slowly" (waited until preload completes)
  • For thick and thin thread

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
web/
input/
14 lines
1 line

Diff 44406

View Options

web/input/input-state-container.react.js

Show All 37 Linesexport type OutboundP2PMessage = {
+supportsAutoRetry: boolean, +supportsAutoRetry: boolean,
}; };
export type SQLiteAPI = { export type SQLiteAPI = {
// read operations // read operations
+getAllInboundP2PMessage: () => Promise<InboundP2PMessage[]>, +getAllInboundP2PMessage: () => Promise<InboundP2PMessage[]>,
+getAllOutboundP2PMessage: () => Promise<OutboundP2PMessage[]>, +getAllOutboundP2PMessage: () => Promise<OutboundP2PMessage[]>,
+getRelatedMessages: (messageID: string) => Promise<ClientDBMessageInfo[]>, +getRelatedMessages: (messageID: string) => Promise<ClientDBMessageInfo[]>,
+getOutboundP2PMessagesByID: (
ids: $ReadOnlyArray<string>,
) => Promise<$ReadOnlyArray<OutboundP2PMessage>>,
kamilUnsubmitted
Done
Inline Actions

I prefer to return OutboundP2PMessage[] here but up to you

kamil: I prefer to return `OutboundP2PMessage[]` here but up to you
tomekAuthorUnsubmitted
Done
Inline Actions

OutboundP2PMessage[] syntax is recommended to be avoided by Flow. But we can use Array<OutboundP2PMessage>

tomek: `OutboundP2PMessage[]` syntax is recommended to be avoided by Flow. But we can use…
// write operations // write operations
+removeInboundP2PMessages: (ids: $ReadOnlyArray<string>) => Promise<void>, +removeInboundP2PMessages: (ids: $ReadOnlyArray<string>) => Promise<void>,
+markOutboundP2PMessageAsSent: ( +markOutboundP2PMessageAsSent: (
messageID: string, messageID: string,
deviceID: string, deviceID: string,
) => Promise<void>, ) => Promise<void>,
+removeOutboundP2PMessagesOlderThan: ( +removeOutboundP2PMessagesOlderThan: (
Show All 9 Lines
View Options

web/input/input-state.js

Show All 37 Linesexport type OutboundP2PMessage = {
+supportsAutoRetry: boolean, +supportsAutoRetry: boolean,
}; };
export type SQLiteAPI = { export type SQLiteAPI = {
// read operations // read operations
+getAllInboundP2PMessage: () => Promise<InboundP2PMessage[]>, +getAllInboundP2PMessage: () => Promise<InboundP2PMessage[]>,
+getAllOutboundP2PMessage: () => Promise<OutboundP2PMessage[]>, +getAllOutboundP2PMessage: () => Promise<OutboundP2PMessage[]>,
+getRelatedMessages: (messageID: string) => Promise<ClientDBMessageInfo[]>, +getRelatedMessages: (messageID: string) => Promise<ClientDBMessageInfo[]>,
+getOutboundP2PMessagesByID: (
ids: $ReadOnlyArray<string>,
) => Promise<$ReadOnlyArray<OutboundP2PMessage>>,
kamilUnsubmitted
Done
Inline Actions

I prefer to return OutboundP2PMessage[] here but up to you

kamil: I prefer to return `OutboundP2PMessage[]` here but up to you
tomekAuthorUnsubmitted
Done
Inline Actions

OutboundP2PMessage[] syntax is recommended to be avoided by Flow. But we can use Array<OutboundP2PMessage>

tomek: `OutboundP2PMessage[]` syntax is recommended to be avoided by Flow. But we can use…
// write operations // write operations
+removeInboundP2PMessages: (ids: $ReadOnlyArray<string>) => Promise<void>, +removeInboundP2PMessages: (ids: $ReadOnlyArray<string>) => Promise<void>,
+markOutboundP2PMessageAsSent: ( +markOutboundP2PMessageAsSent: (
messageID: string, messageID: string,
deviceID: string, deviceID: string,
) => Promise<void>, ) => Promise<void>,
+removeOutboundP2PMessagesOlderThan: ( +removeOutboundP2PMessagesOlderThan: (
Show All 9 Lines