Page MenuHomePhabricator
Differential D13423

[lib] Enable thick thread creation for all the users
ClosedPublic
Actions

Authored by tomek on Sep 23 2024, 3:41 AM.
Tags
None
Referenced Files
F6282380: D13423.id.diff
Fri, Apr 25, 7:57 PM
F6281767: D13423.id.diff
Fri, Apr 25, 7:43 PM
F6281476: D13423.id.diff
Fri, Apr 25, 7:38 PM
F6280928: D13423.id.diff
Fri, Apr 25, 7:27 PM
Unknown Object (File)
Thu, Apr 24, 4:58 PM
Unknown Object (File)
Thu, Apr 24, 4:52 PM
Unknown Object (File)
Wed, Apr 16, 4:07 PM
Unknown Object (File)
Wed, Apr 16, 10:42 AM
View All 94 Files
Subscribers
ashoat

Details

Reviewers
kamil
will
inka
Commits
rCOMM6eea5aaa53ce: [lib] Enable thick thread creation for all the users
Summary

Delete a hook that was limiting this options to the staff users.

https://linear.app/comm/issue/ENG-9360/enable-thick-threads-for-all-the-users

Test Plan

Flow. A sanity check about creating and leaving a thread.

Diff Detail

Repository
rCOMM Comm
Branch
improvements2
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Sep 23 2024, 3:41 AM
Herald added a subscriber: ashoat. · View Herald TranscriptSep 23 2024, 3:42 AM
tomek edited the summary of this revision. (Show Details)Sep 23 2024, 3:43 AM
Harbormaster completed remote builds in B31763: Diff 44409.Sep 23 2024, 3:58 AM
tomek requested review of this revision.Sep 23 2024, 3:58 AM
kamil accepted this revision.Sep 23 2024, 4:15 AM
This revision is now accepted and ready to land.Sep 23 2024, 4:15 AM
tomek updated this revision to Diff 44527.Sep 25 2024, 4:03 AM

Rebase

Harbormaster completed remote builds in B31839: Diff 44527.Sep 25 2024, 4:20 AM
tomek updated this revision to Diff 44690.Sep 30 2024, 8:42 AM

Rebase

inka accepted this revision.Sep 30 2024, 8:47 AM
tomek edited the test plan for this revision. (Show Details)Sep 30 2024, 8:53 AM
Harbormaster completed remote builds in B31934: Diff 44690.Sep 30 2024, 8:59 AM
Closed by commit rCOMM6eea5aaa53ce: [lib] Enable thick thread creation for all the users (authored by tomek). · Explain WhySep 30 2024, 9:00 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM6eea5aaa53ce: [lib] Enable thick thread creation for all the users.

Revision Contents
Changeset List

Diff 44409

View Options

lib/hooks/flag-hooks.js

Loading...
View Options

lib/selectors/thread-selectors.js

Loading...
View Options

lib/shared/thread-actions-utils.js

Loading...
View Options

lib/shared/thread-utils.js

Loading...
View Options

native/chat/chat-thread-list.react.js

Loading...
View Options

native/chat/compose-thread-button.react.js

Loading...
View Options

native/chat/message-list-container.react.js

Loading...
View Options

native/input/input-state-container.react.js

Loading...
View Options

web/chat/thread-list-provider.js

Loading...
View Options

web/input/input-state-container.react.js

Loading...
View Options

web/utils/thread-utils.js

Loading...