Paths

Table of Contentst

[lib] refactor code to update reply count and unread status to function
ClosedPublic
Actions

Authored by kamil on Sep 23 2024, 5:35 AM.

Details

Reviewers

tomek
marcin

Commits

rCOMM0a5c4d4eb6be: [lib] refactor code to update reply count and unread status to function

Summary

ENG-9273.

I need to reuse this function to bump reply count as part of useSendComposableDMOperation.

Did some additional cleanup to avoid selecting the same data multiple times.

Test Plan

Flow, functionality tested later in the stack

Diff Detail

Repository

rCOMM Comm

Branch

land-reply

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Sep 23 2024, 5:35 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptSep 23 2024, 5:35 AM

kamil added a child revision: D13427: [lib] implement reply count for composable DM messages.Sep 23 2024, 5:52 AM

Harbormaster completed remote builds in B31774: Diff 44421.Sep 23 2024, 5:56 AM

kamil published this revision for review.Sep 23 2024, 6:19 AM

tomek accepted this revision.Sep 23 2024, 6:33 AM

tomek added inline comments.

lib/shared/dm-ops/process-dm-ops.js
224 ↗	(On Diff #44421)	I guess we don't have to check this condition

This revision is now accepted and ready to land.Sep 23 2024, 6:33 AM

rebase

Harbormaster completed remote builds in B31779: Diff 44439.Sep 23 2024, 8:47 AM

Closed by commit rCOMM0a5c4d4eb6be: [lib] refactor code to update reply count and unread status to function (authored by kamil). · Explain WhySep 23 2024, 8:49 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM0a5c4d4eb6be: [lib] refactor code to update reply count and unread status to function.

Revision Contents
Changeset List

Path

Size

lib/

shared/

dm-ops/

dm-op-utils.js

105 lines

process-dm-ops.js

96 lines

Diff 44439

View Options

lib/shared/dm-ops/dm-op-utils.js