Paths

Table of Contentst

Differential D13421

[identity] Relax conditions for device list reorder
ClosedPublic
Actions

Authored by bartek on Mon, Sep 23, 2:54 AM.

Tags

None

Referenced Files

	F2842193: D13421.id44553.diff
	Sun, Sep 29, 12:25 PM

	F2841632: D13421.diff
	Sun, Sep 29, 10:29 AM

	F2839969: D13421.diff
	Sun, Sep 29, 4:09 AM

	F2835664: D13421.diff
	Sat, Sep 28, 2:20 PM

	Unknown Object (File)
	Wed, Sep 25, 1:29 AM

	Unknown Object (File)
	Wed, Sep 25, 1:01 AM

Subscribers

Details

Reviewers

Commits

rCOMM16b1b1e50d45: [identity] Relax conditions for device list reorder

Summary

Address ENG-9272.
Made v1 login RPCs able to reorder device list even if new logout flow was used (DDB devices data doesn't match device list).
Updated some log messages to be more meaningful and used redact_sensitive_data in more places.

Test Plan

Registered a user
Used "Primary device logout" to log out. This left a singleton device list on Identity.
Logged in with v1 Login on mobile.
- Device list was reordered. An info log was displayed about mismatch but no error.

Manually modified DDB to contain device that is not on device list
Used v1 login. Warn was displayed about corrupt state

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Mon, Sep 23, 2:54 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMon, Sep 23, 2:54 AM

Harbormaster completed remote builds in B31761: Diff 44407.Mon, Sep 23, 3:11 AM

bartek published this revision for review.Mon, Sep 23, 3:33 AM

varun accepted this revision.Tue, Sep 24, 11:47 AM

varun added inline comments.

services/identity/src/database/device_list.rs
1950 ↗	(On Diff #44407)

This revision is now accepted and ready to land.Tue, Sep 24, 11:47 AM

Closed by commit rCOMM16b1b1e50d45: [identity] Relax conditions for device list reorder (authored by bartek). · Explain WhyWed, Sep 25, 8:36 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM16b1b1e50d45: [identity] Relax conditions for device list reorder.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

database/

38 lines

Diff 44553

services/identity/src/database/device_list.rs

Loading...