Page MenuHomePhabricator

[lib] Update thick thread avatars logic
ClosedPublic

Authored by tomek on Sep 25 2024, 8:33 AM.
Tags
None
Referenced Files
F3340493: D13462.diff
Thu, Nov 21, 9:51 PM
Unknown Object (File)
Sun, Nov 10, 4:19 PM
Unknown Object (File)
Sun, Nov 10, 1:05 AM
Unknown Object (File)
Fri, Nov 8, 11:06 PM
Unknown Object (File)
Fri, Nov 8, 11:06 PM
Unknown Object (File)
Fri, Nov 8, 3:01 AM
Unknown Object (File)
Fri, Nov 8, 3:01 AM
Unknown Object (File)
Fri, Nov 1, 7:13 AM
Subscribers
None

Details

Summary

We should correctly select thick thread avatar based on user avatars.

https://linear.app/comm/issue/ENG-9374/thread-avatars-not-using-user-avatars-for-dms

Test Plan

Created personal and private thick threads and verified that on a thread list their avatars are correct, and before this diff they were incorrect.

Diff Detail

Repository
rCOMM Comm
Branch
improvements2
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek added inline comments.
lib/shared/avatar-utils.js
7 ↗(On Diff #44552)

Shortened the import

293 ↗(On Diff #44552)

Simplified this expression - it didn't make too much sense in the previous form

tomek requested review of this revision.Sep 25 2024, 8:51 AM
This revision is now accepted and ready to land.Sep 25 2024, 8:54 AM
This revision was automatically updated to reflect the committed changes.