Page MenuHomePhabricator
Differential D13488

[lib] rename `userSupportsThickThreads` -> `userHasDeviceList`
ClosedPublic
Actions

Authored by kamil on Sep 26 2024, 3:54 AM.
Tags
None
Referenced Files
F3262199: D13488.id44596.diff
Fri, Nov 15, 11:38 PM
F3261760: D13488.id44676.diff
Fri, Nov 15, 11:25 PM
Unknown Object (File)
Sun, Nov 10, 4:18 PM
Unknown Object (File)
Fri, Nov 8, 3:02 AM
Unknown Object (File)
Fri, Nov 8, 3:02 AM
Unknown Object (File)
Fri, Nov 1, 4:22 PM
Unknown Object (File)
Mon, Oct 21, 8:43 AM
Unknown Object (File)
Sun, Oct 20, 9:32 PM
View All 34 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMM2b2293c66758: [lib] rename `userSupportsThickThreads` -> `userHasDeviceList`
Summary

ENG-9394

Previous name was incorrect, user supports thick thread when is registered to Identity.

Depends on D13487

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Sep 26 2024, 3:54 AM
kamil held this revision as a draft.
kamil added a child revision: D13489: [lib] implement checking if user supports thick thread.Sep 26 2024, 3:59 AM
Harbormaster completed remote builds in B31878: Diff 44596.Sep 26 2024, 4:11 AM
kamil published this revision for review.Sep 26 2024, 4:22 AM
ashoat accepted this revision.Sep 26 2024, 7:55 AM
ashoat added inline comments.
lib/shared/thread-utils.js
1804–1805

We do a similar check in several places which is just deviceList && devices.length > 0. We could consider factoring it out as well, but I'm not sure

This revision is now accepted and ready to land.Sep 26 2024, 7:55 AM
kamil added inline comments.Sep 30 2024, 4:54 AM
lib/shared/thread-utils.js
1804–1805

The only places I found that are not part of this diff are:

  • here but this is removed in D13496
  • check introduced here D13486 but it is using a different type - UsersRawDeviceLists
Closed by commit rCOMM2b2293c66758: [lib] rename `userSupportsThickThreads` -> `userHasDeviceList` (authored by kamil). · Explain WhySep 30 2024, 4:58 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM2b2293c66758: [lib] rename `userSupportsThickThreads` -> `userHasDeviceList`.

Revision Contents
Changeset List

PathSize
lib/
hooks/
17 lines
shared/
dm-ops/
7 lines
4 lines
4 lines
4 lines

Diff 44596

View Options

lib/hooks/relationship-hooks.js

Loading...
View Options

lib/shared/dm-ops/dm-op-utils.js

Loading...
View Options

lib/shared/search-utils.js

Loading...
View Options

lib/shared/thread-actions-utils.js

Loading...
View Options

lib/shared/thread-utils.js

Loading...