Page MenuHomePhabricator
Differential D13509

[native] join community alert handler
Changes PlannedPublic
Actions

Authored by varun on Sep 27 2024, 1:03 PM.
Tags
None
Referenced Files
F3263330: D13509.diff
Sat, Nov 16, 12:03 AM
Unknown Object (File)
Thu, Nov 14, 1:06 PM
Unknown Object (File)
Fri, Nov 1, 5:35 AM
Unknown Object (File)
Sun, Oct 27, 4:11 PM
Unknown Object (File)
Sun, Oct 27, 4:11 PM
Unknown Object (File)
Sun, Oct 27, 4:10 PM
Unknown Object (File)
Oct 15 2024, 6:30 AM
Unknown Object (File)
Oct 12 2024, 12:51 AM
View All 22 Files
Subscribers
tomek

Details

Reviewers
ashoat
Summary

we'll use this handler to determine when to display modal containing list of communities to user

Depends on D13508

Test Plan

confirmed that redux was successfully updated with the new alert data and that the modal was displayed

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Sep 27 2024, 1:03 PM
Herald added a subscriber: tomek. · View Herald TranscriptSep 27 2024, 1:03 PM
varun published this revision for review.Sep 27 2024, 1:04 PM

need to move to lib. publishing and then will plan changes

varun planned changes to this revision.Sep 27 2024, 1:04 PM

this handler component should be in lib

Harbormaster completed remote builds in B31916: Diff 44657.Sep 27 2024, 1:19 PM
ashoat requested changes to this revision.Sep 28 2024, 9:37 AM
ashoat added inline comments.
lib/utils/push-alerts.js
39

Wait so you want to show this screen once a day...?

ashoat added a comment.Sep 28 2024, 9:37 AM

this handler component should be in lib

Sounds complicated given navigation differences

Revision Contents
Changeset List

PathSize
lib/
utils/
5 lines
native/
components/
74 lines
2 lines

Diff 44657

View Options

lib/utils/push-alerts.js

Loading...
View Options

native/components/join-community-alert-handler.react.js

Loading...
View Options

native/root.react.js

Loading...