Page MenuHomePhabricator

[keyserver][lib] Blob client function to remove multiple holders
ClosedPublic

Authored by bartek on Sep 30 2024, 3:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 11:35 AM
Unknown Object (File)
Thu, Dec 19, 11:34 AM
Unknown Object (File)
Thu, Dec 19, 11:34 AM
Unknown Object (File)
Fri, Nov 29, 10:47 PM
Unknown Object (File)
Mon, Nov 25, 8:58 PM
Unknown Object (File)
Mon, Nov 25, 12:04 PM
Unknown Object (File)
Fri, Nov 22, 4:32 PM
Unknown Object (File)
Fri, Nov 22, 4:32 PM
Subscribers

Details

Summary

Similiarly to assignMultipleHolders(), added a blob client function to remove multiple holders.
Added a keyserver wrapper for this function which provides HTTP headers with CSAT.

Test Plan

Called the function from keyserver against local Blob Service. Verified that requested holders were removed from DDB

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Sep 30 2024, 4:05 AM

I'm aware types are not perfect, I described cleanup/refactor plan in ENG-9422

lib/utils/blob-service.js
178

I lost this in rebase

lib/utils/blob-service.js
163–167

It's a bit unusual that this union of disjoint types doesn't have a single property to disambiguate. I'd consider something like +result: 'success' | 'error' | 'failedRequests', or (perhaps easier) to make failedRequests a sub-case of error: true

This revision is now accepted and ready to land.Oct 2 2024, 12:56 AM