Page MenuHomePhabricator

[native] Fix crash in NUX
ClosedPublic

Authored by inka on Mon, Sep 30, 5:49 AM.
Tags
None
Referenced Files
F2987120: D13520.id44741.diff
Wed, Oct 16, 2:33 PM
F2986488: D13520.id44683.diff
Wed, Oct 16, 1:58 PM
F2984032: D13520.diff
Wed, Oct 16, 11:53 AM
F2982717: D13520.id.diff
Wed, Oct 16, 4:53 AM
Unknown Object (File)
Sun, Oct 13, 11:20 PM
Unknown Object (File)
Sat, Oct 12, 6:26 AM
Unknown Object (File)
Sat, Oct 12, 1:05 AM
Unknown Object (File)
Fri, Oct 11, 8:30 AM
Subscribers

Details

Summary

issue: ENG-9375
If a dev kills the app while it is showing the NUX, then after they reopen they will get this error: "button should be registered with nuxTipContext"
This happens because for dev we remember the navigation state. When the navigation state is rehydrated, the buttons have not yet been mounted, so they are not registered with the context, resulting in the error.
Because this is for dev only, and because we expect the NUX tips to only be shown at the start of the app over the chat list, I think we should just reset the nav state if NUX tips are present.

Test Plan

Created a new user -> saw the NUX tips -> navigated to a tip that points to a button -> closed the app -> opened the app
Before this resulted in an error on the screen. After this change the error doesn't appear. The user sees the chat list.

Diff Detail

Repository
rCOMM Comm
Branch
inka/nux_crash
Lint
No Lint Coverage
Unit
No Test Coverage