This diff increments Redux version and changes web codeVersion check for keyserver hasMinCodeVersion check to NEXT_CODE_VERSION.
Details
Details
Will go through Test Plan a couple times in my environment.
- Patch in this diff
- Rebase and "stop on" (edit) "DUMMY` commit
- Run yarn dev everywhere and observe the ThreadInfos via Redux DevTools. Observe that there are member permissions for thin threads.
- git rebase --continue
- Observe the logs in browser dev tools and confirm that migration ran successfully
- Observe that thin threads no longer have member permissions via Redux DevTools.
Before (thin, with member permissions):
Before (thick, with member permissions):
After (thin, WITHOUT member permissions):
After (thick, still WITH member permissions):
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| web/redux/persist-constants.js | ||
|---|---|---|
| 6 | Is this the correct place to increment things? Is there anywhere else I need to change a value to be kept in sync with this one (eg on native?) From a quick search it seems like this storeVersion constant is only accessed in web? | |
| web/redux/persist-constants.js | ||
|---|---|---|
| 6 | I think we're trying to keep these versions in sync, so it would be great if you could bump native/redux/persist.js too You may or may not need to add a no-op migration to native, eg. [84]: (state: AppState) => ({ state, ops: [], }), Probably fine to omit, but please test! | |