Paths

Table of Contentst

Differential D13561

[web] Flip the switch to strip member permissions from `web`
AcceptedPublic
Actions

Authored by atul on Tue, Oct 1, 10:59 AM.

Tags

None

Referenced Files

	F2868446: D13561.id44795.diff
	Wed, Oct 2, 3:09 PM

	F2864125: D13561.id.diff
	Wed, Oct 2, 5:50 AM

	F2863921: D13561.id44790.diff
	Wed, Oct 2, 5:27 AM

	F2863248: D13561.diff
	Wed, Oct 2, 3:47 AM

	Unknown Object (File)
	Tue, Oct 1, 10:58 PM

	Unknown Object (File)
	Tue, Oct 1, 10:49 PM

	Unknown Object (File)
	Tue, Oct 1, 1:30 PM

	Unknown Object (File)
	Tue, Oct 1, 1:30 PM

View All 10 Files

Subscribers

Details

Reviewers

Summary

WARNING: Still need to do testing before landing.

This diff increments Redux version and changes web codeVersion check for keyserver hasMinCodeVersion check to NEXT_CODE_VERSION.

Test Plan

Will go through Test Plan a couple times in my environment.

Diff Detail

Repository

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Tue, Oct 1, 10:59 AM

Herald added a subscriber: tomek. · View Herald TranscriptTue, Oct 1, 10:59 AM

atul added inline comments.Tue, Oct 1, 11:01 AM

web/redux/persist-constants.js
6	Is this the correct place to increment things? Is there anywhere else I need to change a value to be kept in sync with this one (eg on `native`?) From a quick search it seems like this `storeVersion` constant is only accessed in `web`?

Harbormaster completed remote builds in B31993: Diff 44790.Tue, Oct 1, 11:16 AM

atul requested review of this revision.Tue, Oct 1, 11:16 AM

ashoat accepted this revision.Tue, Oct 1, 11:21 AM

ashoat added inline comments.

web/redux/persist-constants.js
6	I think we're trying to keep these versions in sync, so it would be great if you could bump `native/redux/persist.js` too You may or may not need to add a no-op migration to `native`, eg. [84]: (state: AppState) => ({ state, ops: [], }), Probably fine to omit, but please test!

This revision is now accepted and ready to land.Tue, Oct 1, 11:21 AM

bumped native persist version and added no-op migration

Harbormaster completed remote builds in B31995: Diff 44795.Tue, Oct 1, 12:21 PM

fix

atul mentioned this in D12790: [web] Introduce `web` migration to strip member permissions.Tue, Oct 1, 3:44 PM

Harbormaster completed remote builds in B32006: Diff 44810.Tue, Oct 1, 3:57 PM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

fetchers/

thread-fetchers.js

4 lines

web/

redux/

persist-constants.js

2 lines

Diff 44790

keyserver/src/fetchers/thread-fetchers.js

Loading...

web/redux/persist-constants.js

Loading...