Paths

Table of Contentst

[identity] Treat empty auth metadata as invalid CSAT
ClosedPublic
Actions

Authored by bartek on Oct 1 2024, 7:52 AM.

Tags

None

Referenced Files

	F3513017: D13558.id44757.diff
	Sat, Dec 21, 9:45 PM

	Unknown Object (File)
	Fri, Dec 6, 2:43 AM

	Unknown Object (File)
	Thu, Dec 5, 12:15 AM

	Unknown Object (File)
	Wed, Dec 4, 4:41 PM

	Unknown Object (File)
	Wed, Dec 4, 4:40 PM

	Unknown Object (File)
	Wed, Dec 4, 4:40 PM

	Unknown Object (File)
	Wed, Dec 4, 3:46 PM

	Unknown Object (File)
	Wed, Dec 4, 12:23 PM

View All 46 Files

Subscribers

ashoat

tomek

Details

Reviewers

varun
will

Commits

rCOMMe2f9c9a9db31: [identity] Treat empty auth metadata as invalid CSAT

Summary

ENG-9458.
Empty userID or deviceID makes DDB complain.

Test Plan

Called VerifyUserAccessToken RPC with empty user ID. The RPC errored before, now returns false.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Oct 1 2024, 7:52 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 1 2024, 7:52 AM

bartek published this revision for review.Oct 1 2024, 7:55 AM

Harbormaster completed remote builds in B31986: Diff 44757.Oct 1 2024, 8:12 AM

varun accepted this revision.Oct 1 2024, 10:26 AM

This revision is now accepted and ready to land.Oct 1 2024, 10:26 AM

Closed by commit rCOMMe2f9c9a9db31: [identity] Treat empty auth metadata as invalid CSAT (authored by bartek). · Explain WhyOct 1 2024, 11:07 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMe2f9c9a9db31: [identity] Treat empty auth metadata as invalid CSAT.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

database/

token.rs

7 lines

Diff 44791

View Options

services/identity/src/database/token.rs

[identity] Treat empty auth metadata as invalid CSATClosedPublicActions