[keyserver][lib] Blob client function to remove multiple holders
ClosedPublic
Actions

Authored by bartek on Sep 30 2024, 3:10 AM.

Details

Reviewers

kamil
tomek

Commits

rCOMM7d84edf2d087: [keyserver][lib] Blob client function to remove multiple holders

Summary

Similiarly to assignMultipleHolders(), added a blob client function to remove multiple holders.
Added a keyserver wrapper for this function which provides HTTP headers with CSAT.

Test Plan

Called the function from keyserver against local Blob Service. Verified that requested holders were removed from DDB

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Sep 30 2024, 3:10 AM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptSep 30 2024, 3:10 AM

bartek added a child revision: D13512: [keyserver] Remove holders in upload deleters.Sep 30 2024, 3:14 AM

Harbormaster completed remote builds in B31919: Diff 44664.Sep 30 2024, 3:27 AM

I'm aware types are not perfect, I described cleanup/refactor plan in ENG-9422

lib/utils/blob-service.js
178 ↗	(On Diff #44664)	I lost this in rebase

ashoat added inline comments.Sep 30 2024, 5:32 AM

lib/utils/blob-service.js
163–167 ↗	(On Diff #44664)	It's a bit unusual that this union of disjoint types doesn't have a single property to disambiguate. I'd consider something like `+result: 'success' \| 'error' \| 'failedRequests'`, or (perhaps easier) to make `failedRequests` a sub-case of `error: true`