Page MenuHomePhabricator

[landing] Set redirectUrl so that Warpcast redirects back to Comm
ClosedPublic

Authored by ashoat on Oct 2 2024, 8:37 PM.
Tags
None
Referenced Files
F3513143: D13580.id44843.diff
Sat, Dec 21, 10:53 PM
F3512948: D13580.diff
Sat, Dec 21, 9:16 PM
Unknown Object (File)
Sat, Nov 23, 4:38 AM
Unknown Object (File)
Nov 10 2024, 8:22 AM
Unknown Object (File)
Nov 10 2024, 3:58 AM
Unknown Object (File)
Nov 8 2024, 10:38 PM
Unknown Object (File)
Nov 8 2024, 1:48 PM
Unknown Object (File)
Nov 1 2024, 2:38 PM
Subscribers

Details

Summary

Thank you @deodad for this one-line change 🙏

back-from-warpcast here is just a random string. DeepLinksContextProvider does nothing if it can't parse the URL, and in this case we're okay with that since we only call Warpcast when Comm is on the "Connect Farcaster" screen.

Depends on D13579

Test Plan

Testing the Farcaster connection screen in a dev environment is kind of complicated, so I created this doc on Notion. I followed the instructions there for both physical iOS and Android devices

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Draft.Oct 2 2024, 8:43 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.