Page MenuHomePhabricator
Differential D13620

[landing] Fix ConnectFarcaster
ClosedPublic
Actions

Authored by ashoat on Oct 4 2024, 3:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 9:06 AM
Unknown Object (File)
Wed, Dec 18, 9:06 AM
Unknown Object (File)
Wed, Dec 18, 9:06 AM
Unknown Object (File)
Wed, Dec 18, 9:06 AM
Unknown Object (File)
Thu, Dec 5, 10:36 PM
Unknown Object (File)
Thu, Dec 5, 5:46 AM
Unknown Object (File)
Wed, Dec 4, 9:23 PM
Unknown Object (File)
Fri, Nov 29, 9:04 PM
View All 36 Files
Subscribers
tomek

Details

Reviewers
varun
will
Commits
rCOMM25c1c1f67952: [landing] Fix ConnectFarcaster
Summary

Addresses ENG-9506. @horsefacts helped me out here. We should be waiting for connect to finish before calling signIn.

Test Plan

I tested the SIWF flow on Android following this doc

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Oct 4 2024, 3:31 PM
Herald added a subscriber: tomek. · View Herald TranscriptOct 4 2024, 3:31 PM
ashoat published this revision for review.Oct 4 2024, 3:32 PM
varun accepted this revision.Oct 4 2024, 3:32 PM
This revision is now accepted and ready to land.Oct 4 2024, 3:32 PM
ashoat edited the summary of this revision. (Show Details)Oct 4 2024, 3:33 PM
This revision was landed with ongoing or failed builds.Oct 4 2024, 3:41 PM
Closed by commit rCOMM25c1c1f67952: [landing] Fix ConnectFarcaster (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM25c1c1f67952: [landing] Fix ConnectFarcaster.
Harbormaster completed remote builds in B32083: Diff 44917.Oct 4 2024, 3:49 PM

Revision Contents
Changeset List

PathSize
landing/
10 lines

Diff 44917

View Options

landing/connect-farcaster.react.js

Loading...