Paths

Table of Contentst

Differential D13624

[landing] Make buttons variable width
ClosedPublic
Actions

Authored by ashoat on Oct 7 2024, 12:06 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 17, 5:27 AM

	Unknown Object (File)
	Sat, Nov 9, 3:55 AM

	Unknown Object (File)
	Sat, Nov 9, 2:21 AM

	Unknown Object (File)
	Sat, Nov 2, 10:38 PM

	Unknown Object (File)
	Thu, Oct 24, 7:29 AM

	Unknown Object (File)
	Wed, Oct 23, 7:55 PM

	Unknown Object (File)
	Wed, Oct 23, 7:55 PM

	Unknown Object (File)
	Wed, Oct 23, 7:55 PM

View All 30 Files

Subscribers

Details

Reviewers

Commits

rCOMM310fd6416738: [landing] Make buttons variable width

Summary

The <Button> component in landing is used in two places:

It's used in the team page. From testing on Chrome, I can see that flex-basis has no effect there. Chrome explains why:
The main use is the download page. I'm about to introduce a new button, so I actually want to change the grid layout there. See test plan for before/after

Test Plan

Check how team and download pages look in my local dev environment

before	after

Diff Detail

Repository

Branch

ashoat/landing

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Oct 7 2024, 12:06 PM

Herald added a subscriber: tomek. · View Herald TranscriptOct 7 2024, 12:06 PM

ashoat edited the summary of this revision. (Show Details)Oct 7 2024, 12:09 PM

ashoat edited the test plan for this revision. (Show Details)

ashoat added inline comments.

landing/download.css
28	Without this change, we see the following:

ashoat attached a referenced file: F2918723: Screenshot 2024-10-07 at 3.09.14 PM.png. (Show Details)Oct 7 2024, 12:10 PM

ashoat added a child revision: D13625: [landing] Add link to web app from download page.Oct 7 2024, 12:14 PM

Harbormaster completed remote builds in B32090: Diff 44946.Oct 7 2024, 12:24 PM

ashoat requested review of this revision.Oct 7 2024, 12:24 PM

Just looked at the download page on safari and it looks really bad right now:

Screenshot 2024-10-07 at 3.40.08 PM.png (1×1 px, 85 KB)

Can you confirm before landing that your changes fix this issue, too?

This revision is now accepted and ready to land.Oct 7 2024, 12:40 PM

Yeah that's flex-basis: 120px; for sure. Here's what it looks like now in Safari:

Screenshot 2024-10-07 at 4.00.29 PM.png (458×914 px, 46 KB)

thanks!

Closed by commit rCOMM310fd6416738: [landing] Make buttons variable width (authored by ashoat). · Explain WhyOct 7 2024, 1:03 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM310fd6416738: [landing] Make buttons variable width.

Revision Contents
Changeset List

Path

Size

landing/

1 line

1 line

Diff 44946

landing/button.css

Loading...

landing/download.css

Loading...