[keyserver] simplify verifyUserLoggedIn
ClosedPublic
Actions

Authored by varun on Oct 9 2024, 12:53 PM.

Tags

None

Referenced Files

	F3516974: D13665.id45020.diff
	Sun, Dec 22, 3:55 PM

	Unknown Object (File)
	Thu, Nov 28, 6:06 PM

	Unknown Object (File)
	Thu, Nov 28, 1:00 PM

	Unknown Object (File)
	Thu, Nov 28, 12:52 PM

	Unknown Object (File)
	Nov 14 2024, 3:00 PM

	Unknown Object (File)
	Nov 9 2024, 2:25 AM

	Unknown Object (File)
	Nov 9 2024, 12:58 AM

	Unknown Object (File)
	Nov 7 2024, 8:51 AM

View All 37 Files

Subscribers

tomek

Details

Reviewers

ashoat
inka

Commits

rCOMMc8a851f8be77: [keyserver] simplify verifyUserLoggedIn

Summary

in the next diff, i split out the auth and save parts of this function into a separate function, so rearranging the code here first

Depends on D13664

Test Plan

read the code carefully

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Oct 9 2024, 12:53 PM

Herald added a subscriber: tomek. · View Herald TranscriptOct 9 2024, 12:53 PM

varun added a child revision: D13666: [keyserver] factor out identity auth and saveIdentityInfo from verifyUserLoggedIn.Oct 9 2024, 12:55 PM

varun edited the summary of this revision. (Show Details)Oct 9 2024, 1:07 PM

Harbormaster completed remote builds in B32147: Diff 45020.Oct 9 2024, 1:11 PM

varun requested review of this revision.Oct 9 2024, 1:11 PM

ashoat accepted this revision.Oct 9 2024, 5:03 PM

This revision is now accepted and ready to land.Oct 9 2024, 5:03 PM

Closed by commit rCOMMc8a851f8be77: [keyserver] simplify verifyUserLoggedIn (authored by varun). · Explain WhyOct 10 2024, 12:07 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMc8a851f8be77: [keyserver] simplify verifyUserLoggedIn.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

user/

5 lines

Diff 45077

View Options

keyserver/src/user/login.js

[keyserver] simplify verifyUserLoggedInClosedPublicActions