Details

Reviewers

varun
will

Commits

rCOMM629fa7151da7: [lib][native] Use ensjs for ENSCache name/address resolution

Summary

This addresses ENG-5308, and fixes basename resolution (eg. ashoat.base.eth) in getNamesForAddresses (ENG-9569).

I wasn't able to update getAvatarURIForAddress to use ensjs; see context here. As a result, ENSCache currently needs both an Ethers.js provider and a Viem client to work. I added ENSWrapper as an abstraction layer over these.

Test Plan

I added new unit tests. Before the changes in this diff, the new nfthreat.base.eth unit test for getNamesForAddresses would fail. Now it passes

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/basenames

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Oct 11 2024, 5:08 PM

Herald added a subscriber: tomek. · View Herald TranscriptOct 11 2024, 5:08 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 11 2024, 5:50 PM

Harbormaster failed remote builds in B32200: Diff 45096!

ashoat added a parent revision: D13702: [native] Add Babel plugins to transform crypto packages on React Native.Oct 13 2024, 7:37 PM

ashoat edited the test plan for this revision. (Show Details)

Rebase on D13702. Hopefully should be working now!

Harbormaster completed remote builds in B32217: Diff 45133.Oct 13 2024, 7:59 PM

ashoat requested review of this revision.Oct 13 2024, 7:59 PM

will accepted this revision.Oct 14 2024, 3:01 PM

This revision is now accepted and ready to land.Oct 14 2024, 3:01 PM

Two more changes:

I ended up needing to patch TextEncoder and TextDecoder, like when I last tried integrating Viem a year ago. I took the changes from my patch from then
Bump queryTimeout to 30 seconds, as resolving an "offchain" ENS name such as a basename can take longer

Harbormaster completed remote builds in B32242: Diff 45181.Oct 14 2024, 5:17 PM

Fix up initENSCache on keyserver

Harbormaster completed remote builds in B32243: Diff 45182.Oct 14 2024, 6:12 PM

Factor out getAlchemyMainnetViemClientWithENSContracts, as I did with createViemPublicClient in the patch linked two updates above

Harbormaster completed remote builds in B32244: Diff 45183.Oct 14 2024, 6:57 PM

Fix comment

This revision was landed with ongoing or failed builds.Oct 14 2024, 8:38 PM

Closed by commit rCOMM629fa7151da7: [lib][native] Use ensjs for ENSCache name/address resolution (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM629fa7151da7: [lib][native] Use ensjs for ENSCache name/address resolution.

Harbormaster completed remote builds in B32246: Diff 45185.Oct 14 2024, 8:45 PM

[lib][native] Use ensjs for ENSCache name/address resolution
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 45096

lib/components/ens-cache-provider.react.js

lib/flow-typed/npm/@ensdomains/ensjs_vx.x.x.js

lib/flow-typed/npm/viem_vx.x.x.js

lib/package.json

lib/utils/ens-cache.js

lib/utils/ens-cache.test.js

lib/utils/ens-wrapper.js

lib/utils/reverse-records.js

lib/utils/viem-utils.js

lib/utils/wagmi-utils.js

native/root.react.js

native/utils/ethers-utils.js

yarn.lock

[lib][native] Use ensjs for ENSCache name/address resolutionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45096

lib/components/ens-cache-provider.react.js

lib/flow-typed/npm/@ensdomains/ensjs_vx.x.x.js

lib/flow-typed/npm/viem_vx.x.x.js

lib/package.json

lib/utils/ens-cache.js

lib/utils/ens-cache.test.js

lib/utils/ens-wrapper.js

lib/utils/reverse-records.js

lib/utils/viem-utils.js

lib/utils/wagmi-utils.js

native/root.react.js

native/utils/ethers-utils.js

yarn.lock

[lib][native] Use ensjs for ENSCache name/address resolution
ClosedPublic
Actions

Revision Contents
Changeset List