Page MenuHomePhabricator

[native] Upgrade to react-native@0.70.15
ClosedPublic

Authored by ashoat on Oct 12 2024, 12:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 15, 2:51 AM
Unknown Object (File)
Fri, Nov 15, 1:06 AM
Unknown Object (File)
Thu, Nov 14, 2:52 PM
Unknown Object (File)
Thu, Nov 14, 12:53 PM
Unknown Object (File)
Tue, Nov 12, 4:16 PM
Unknown Object (File)
Tue, Nov 12, 3:50 PM
Unknown Object (File)
Tue, Nov 12, 2:15 PM
Unknown Object (File)
Thu, Nov 7, 3:05 PM
Subscribers

Details

Summary

Was investigating if this introduce support in Hermes for named capture groups to address some issues integrating Viem in ENG-5308. It didn't end up helping, but I figured I'd put the diff up anyways.

Test Plan

Before landing, will confirm it passes CI, and that iOS / Android builds on dev / release

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 12 2024, 12:30 PM
Harbormaster failed remote builds in B32201: Diff 45097!
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 13 2024, 3:02 PM
Harbormaster failed remote builds in B32204: Diff 45100!
ashoat edited the test plan for this revision. (Show Details)
native/ios/Podfile
89–91 ↗(On Diff #45131)

Context on why we can remove these lines is here

native/package.json
81 ↗(On Diff #45131)

Context on why this upgrade was necessary here

This revision is now accepted and ready to land.Oct 14 2024, 7:28 AM
This revision was automatically updated to reflect the committed changes.