Page MenuHomePhabricator
Differential D13675

[lib][web] Narrow ChatMessageInfoItem to ComposableChatMessageInfoItem where appropriate
ClosedPublic
Actions

Authored by ashoat on Oct 9 2024, 8:23 PM.
Tags
None
Referenced Files
F5129005: D13675.diff
Thu, Apr 3, 11:21 PM
Unknown Object (File)
Wed, Apr 2, 8:44 PM
Unknown Object (File)
Sat, Mar 15, 3:17 AM
Unknown Object (File)
Wed, Mar 12, 8:50 AM
Unknown Object (File)
Wed, Mar 5, 7:54 PM
Unknown Object (File)
Mar 3 2025, 6:18 AM
Unknown Object (File)
Feb 27 2025, 3:07 PM
Unknown Object (File)
Feb 17 2025, 10:51 AM
View All 69 Files
Subscribers
None

Details

Reviewers
tomek
Commits
rCOMMcf32e540a169: [lib][web] Narrow ChatMessageInfoItem to ComposableChatMessageInfoItem where…
Summary

This will make a following diff a little easier.

Depends on D13674

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Oct 9 2024, 8:23 PM
ashoat added a child revision: D13676: [native] Remove TooltipInlineEngagement from RobotextMessageTooltipButton.
Harbormaster completed remote builds in B32159: Diff 45034.Oct 9 2024, 8:57 PM
ashoat requested review of this revision.Oct 9 2024, 8:57 PM
tomek accepted this revision.Oct 11 2024, 5:01 AM
tomek added inline comments.
lib/selectors/chat-selectors.js
286 ↗(On Diff #45034)

Is there a reason not to use composable as the name?

This revision is now accepted and ready to land.Oct 11 2024, 5:01 AM
ashoat retitled this revision from [lib][web] Narrow ChatMessageInfoItem to ComposedChatMessageInfoItem where appropriate to [lib][web] Narrow ChatMessageInfoItem to ComposableChatMessageInfoItem where appropriate.Oct 13 2024, 5:17 PM
ashoat updated this revision to Diff 45104.Oct 13 2024, 5:20 PM

ComposedChatMessageInfoItem -> ComposableChatMessageInfoItem

Harbormaster completed remote builds in B32208: Diff 45104.Oct 13 2024, 5:38 PM
Closed by commit rCOMMcf32e540a169: [lib][web] Narrow ChatMessageInfoItem to ComposableChatMessageInfoItem where… (authored by ashoat). · Explain WhyOct 13 2024, 6:43 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMcf32e540a169: [lib][web] Narrow ChatMessageInfoItem to ComposableChatMessageInfoItem where….

Revision Contents
Changeset List

Diff 45104

View Options

lib/selectors/chat-selectors.js

This file contains generated code, which does not normally need to be reviewed. Show File Contents
View Options

web/chat/composed-message.react.js

This file contains generated code, which does not normally need to be reviewed. Show File Contents
View Options

web/chat/edit-message-provider.js

This file contains generated code, which does not normally need to be reviewed. Show File Contents
View Options

web/chat/edit-text-message.react.js

This file contains generated code, which does not normally need to be reviewed. Show File Contents
View Options

web/chat/failed-send.react.js

Loading...
View Options

web/chat/message.react.js

Loading...
View Options

web/chat/multimedia-message-send-failed.js

Loading...
View Options

web/chat/multimedia-message.react.js

Loading...
View Options

web/chat/text-message-send-failed.js

Loading...
View Options

web/chat/text-message.react.js

Loading...
View Options

web/tooltips/tooltip-action-utils.js

Loading...