Page MenuHomePhabricator

[native] Remove TooltipInlineEngagement from RobotextMessageTooltipButton
ClosedPublic

Authored by ashoat on Oct 9 2024, 8:24 PM.
Tags
None
Referenced Files
F3366961: D13676.id45035.diff
Mon, Nov 25, 1:11 PM
F3364479: D13676.diff
Mon, Nov 25, 3:57 AM
Unknown Object (File)
Sun, Nov 10, 7:55 AM
Unknown Object (File)
Sun, Nov 10, 7:20 AM
Unknown Object (File)
Sun, Nov 10, 4:51 AM
Unknown Object (File)
Sat, Nov 9, 9:45 PM
Unknown Object (File)
Sat, Nov 9, 7:59 AM
Unknown Object (File)
Sat, Nov 2, 12:23 PM
Subscribers
None

Details

Summary

This was introduced first in D4825 to solve a problem having to do with InlineEngagement appearing over the message.

But for robotext messages, we don't overlap the display of InlineEngagement with the message. As such, this problem doesn't exist for robotext messages, and doesn't need to be solved.

Depends on D13675

Test Plan

Remove TooltipInlineEngagement from text messages and multimedia messages. Observe that the issue described in D4825 appears now. Do the same for robotext messages, and confirm that the issue does not appear.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable