Page MenuHomePhabricator
Differential D13700

[native] Upgrade to react-native@0.70.15
ClosedPublic
Actions

Authored by ashoat on Oct 12 2024, 12:14 PM.
Tags
None
Referenced Files
F3710690: D13700.diff
Wed, Jan 8, 5:22 AM
F3709294: D13700.id45131.diff
Wed, Jan 8, 4:06 AM
F3708720: D13700.id45191.diff
Wed, Jan 8, 3:10 AM
Unknown Object (File)
Mon, Jan 6, 12:58 PM
Unknown Object (File)
Sun, Jan 5, 8:21 AM
Unknown Object (File)
Sun, Jan 5, 8:20 AM
Unknown Object (File)
Sun, Jan 5, 8:20 AM
Unknown Object (File)
Sun, Jan 5, 8:19 AM
View All Files
Subscribers
tomek

Details

Reviewers
varun
will
Commits
rCOMMea4b0bac2723: [native] Upgrade to react-native@0.70.15
Summary

Was investigating if this introduce support in Hermes for named capture groups to address some issues integrating Viem in ENG-5308. It didn't end up helping, but I figured I'd put the diff up anyways.

Test Plan

Before landing, will confirm it passes CI, and that iOS / Android builds on dev / release

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/reactnative
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Oct 12 2024, 12:14 PM
Herald added a subscriber: tomek. · View Herald TranscriptOct 12 2024, 12:14 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 12 2024, 12:30 PM
Harbormaster failed remote builds in B32201: Diff 45097!
ashoat updated this revision to Diff 45100.Oct 13 2024, 2:42 PM

Trying again

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 13 2024, 3:02 PM
Harbormaster failed remote builds in B32204: Diff 45100!
ashoat edited the summary of this revision. (Show Details)Oct 13 2024, 7:04 PM
ashoat edited the test plan for this revision. (Show Details)
ashoat updated this revision to Diff 45131.Oct 13 2024, 7:06 PM

Use expo-image@1.2.3

ashoat added inline comments.Oct 13 2024, 7:10 PM
native/ios/Podfile
89–91

Context on why we can remove these lines is here

native/package.json
81

Context on why this upgrade was necessary here

Harbormaster completed remote builds in B32215: Diff 45131.Oct 13 2024, 7:27 PM
ashoat requested review of this revision.Oct 13 2024, 7:27 PM
will accepted this revision.Oct 14 2024, 7:28 AM
This revision is now accepted and ready to land.Oct 14 2024, 7:28 AM
Closed by commit rCOMMea4b0bac2723: [native] Upgrade to react-native@0.70.15 (authored by ashoat). · Explain WhyOct 14 2024, 10:12 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMea4b0bac2723: [native] Upgrade to react-native@0.70.15.
ashoat mentioned this in D13748: [native] Fix Babel preset patch after React Native 0.70.15 upgrade.Oct 17 2024, 12:50 PM
ashoat mentioned this in rCOMM7d56562e81b9: [native] Fix Babel preset patch after React Native 0.70.15 upgrade.Oct 17 2024, 12:54 PM

Revision Contents
Changeset List

PathSize
native/
ios/
Comm.xcodeproj/
15 lines
3 lines
547 lines
4 lines
patches/
react-native+0.70.15.patch
react-native+0.70.9.patch
210 lines
415 lines

Diff 45131

View Options

native/ios/Comm.xcodeproj/project.pbxproj

Loading...
View Options

native/ios/Podfile

Loading...
View Options

native/ios/Podfile.lock

Loading...
View Options

native/package.json

Loading...
View Options

patches/react-native+0.70.15.patch

Loading...
View Options

patches/react-native+0.70.9.patch

Loading...
View Options

yarn.lock

Loading...