Page MenuHomePhabricator
Differential D13706

[web] Add ellipsis on longer thread names
ClosedPublic
Actions

Authored by angelika on Mon, Oct 14, 8:19 AM.
Tags
None
Referenced Files
F2982460: D13706.diff
Wed, Oct 16, 3:36 AM
Unknown Object (File)
Tue, Oct 15, 4:33 AM
F2974409: Screenshot 2024-10-15 at 13.22.51.png
Tue, Oct 15, 4:24 AM
F2974406: Screenshot 2024-10-15 at 13.21.08.png
Tue, Oct 15, 4:24 AM
Unknown Object (File)
Tue, Oct 15, 3:17 AM
Unknown Object (File)
Tue, Oct 15, 3:15 AM
Unknown Object (File)
Tue, Oct 15, 3:15 AM
Unknown Object (File)
Tue, Oct 15, 3:07 AM
View All 12 Files
Subscribers
ashoat
tomek

Details

Reviewers
inka
kamil
Commits
rCOMM77480058d76e: [web] Add ellipsis on longer thread names
Summary

This diff adds ellipsis to longer thread names

Before:

Screenshot 2024-10-15 at 13.21.08.png (766×2 px, 180 KB)

After:

Screenshot 2024-10-15 at 13.22.51.png (642×2 px, 131 KB)

Test Plan
  1. Create a community with a longer name
  2. Verify that the ellipsis is added when thread name doesn't fit in browser window

Diff Detail

Repository
rCOMM Comm
Branch
@graszka22/ENG-8695
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

angelika created this revision.Mon, Oct 14, 8:19 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMon, Oct 14, 8:19 AM
Harbormaster completed remote builds in B32233: Diff 45171.Mon, Oct 14, 8:47 AM
angelika requested review of this revision.Mon, Oct 14, 8:47 AM
angelika added reviewers: inka, kamil.Tue, Oct 15, 4:23 AM
angelika edited the summary of this revision. (Show Details)
kamil accepted this revision.Tue, Oct 15, 11:38 PM

nit: worth adding a link to the Linear issue in diff summary, this always gives a reviewer a bit more context

This revision is now accepted and ready to land.Tue, Oct 15, 11:38 PM
Closed by commit rCOMM77480058d76e: [web] Add ellipsis on longer thread names (authored by angelika). · Explain WhyWed, Oct 16, 4:50 AM
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMM77480058d76e: [web] Add ellipsis on longer thread names.

Revision Contents
Changeset List

PathSize
web/
navigation-panels/
2 lines

Diff 45171

View Options

web/navigation-panels/chat-thread-ancestors.css

Loading...