Page MenuHomePhabricator
Differential D13716

[lib] Disconnect FID when another device disconnects it
ClosedPublic
Actions

Authored by ashoat on Tue, Oct 15, 11:27 AM.
Tags
None
Referenced Files
F2982448: D13716.id45205.diff
Wed, Oct 16, 3:29 AM
F2982165: D13716.diff
Wed, Oct 16, 1:53 AM
F2979251: D13716.id45205.diff
Tue, Oct 15, 3:35 PM
F2979250: D13716.id45201.diff
Tue, Oct 15, 3:35 PM
F2979207: D13716.id.diff
Tue, Oct 15, 3:34 PM
F2979195: D13716.diff
Tue, Oct 15, 3:34 PM
Subscribers
tomek

Details

Reviewers
will
varun
Commits
rCOMMb1e1966377ee: [lib] Disconnect FID when another device disconnects it
Summary

This addresses ENG-9684.

Depends on D13715

Test Plan
  1. I started with a test account that has been connected to an FID on staging
  2. I opened up a mobile app and a web app logged in as this user
  3. I disconnected the FID on mobile
  4. I refreshed the web app. Prior to these changes, refreshing would not cause the FID to be disconnected on web. After these changes, it does. I was able to check if the FID was connected by seeing if the “Tag Farcaster channel” option appeared for a community that the user is an admin of
  5. On mobile, I then reconnected the FID on staging following these instructions
  6. After reconnecting on mobile, I refreshed the web app and confirmed that the FID was reconnected on web too
  7. Then I added an artificial delay to the findUserIdentities RPC to force a timeout. I refreshed the web app and confirmed that the FID was *not* disconnected

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Tue, Oct 15, 11:27 AM
Herald added a subscriber: tomek. · View Herald TranscriptTue, Oct 15, 11:27 AM
ashoat added inline comments.Tue, Oct 15, 11:28 AM
lib/components/farcaster-data-handler.react.js
39–40

Note that findUserIdentities is unchanged here

ashoat published this revision for review.Tue, Oct 15, 11:28 AM
will accepted this revision.Tue, Oct 15, 11:32 AM
This revision is now accepted and ready to land.Tue, Oct 15, 11:32 AM
Harbormaster completed remote builds in B32253: Diff 45201.Tue, Oct 15, 11:44 AM
Closed by commit rCOMMb1e1966377ee: [lib] Disconnect FID when another device disconnects it (authored by ashoat). · Explain WhyTue, Oct 15, 12:42 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMb1e1966377ee: [lib] Disconnect FID when another device disconnects it.

Revision Contents
Changeset List

PathSize
lib/
components/
29 lines

Diff 45201

View Options

lib/components/farcaster-data-handler.react.js

Loading...