[lib] Do not show sidebar underneath parent if in different tab
AbandonedPublic
Actions

Authored by will on Oct 15 2024, 2:54 PM.

Details

Reviewers

ashoat
varun

Summary

We do not wish to show the sidebars underneath the parent if they already exist as top level items in a different tab.

Depends on D13719

Test Plan

Tested by moving a child thread to a different tab and confirming that it disappeared underneath the parent thread.

Moving the parent thread to a separate tab from its child also resulted in the child disappearing from underneath.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Oct 15 2024, 2:54 PM

Herald added a subscriber: tomek. · View Herald TranscriptOct 15 2024, 2:54 PM

will added a child revision: D13721: [lib/native/web] Enable option to save notif tab of child threads irregardless of parent setting or sidebar type on web and native.Oct 15 2024, 2:59 PM

Harbormaster completed remote builds in B32260: Diff 45212.Oct 15 2024, 3:30 PM

will requested review of this revision.Oct 15 2024, 3:30 PM

ashoat requested changes to this revision.Oct 16 2024, 10:10 AM

ashoat added inline comments.

lib/selectors/chat-selectors.js
171	Can you add a comment here explaining why we're doing this? Does this change make sense for all callsites of `createChatThreadItem`?

This revision now requires changes to proceed.Oct 16 2024, 10:10 AM

Abandoning. This will be performed in the prior diff

will removed a parent revision: D13719: [lib] Show sidebars in top level if parent thread is in a separate tab.Oct 16 2024, 11:18 AM

will removed a child revision: D13721: [lib/native/web] Enable option to save notif tab of child threads irregardless of parent setting or sidebar type on web and native.

Revision Contents
Changeset List

Path

Size

lib/

selectors/

chat-selectors.js

4 lines

Diff 45212

View Options

lib/selectors/chat-selectors.js

[lib] Do not show sidebar underneath parent if in different tabAbandonedPublicActions