Page MenuHomePhabricator
Differential D13725

[lib] Show staff alerts when an operation isn't processed
ClosedPublic
Actions

Authored by tomek on Oct 16 2024, 7:05 AM.
Tags
None
Referenced Files
F3339557: D13725.id45222.diff
Thu, Nov 21, 8:05 PM
F3339203: D13725.diff
Thu, Nov 21, 7:03 PM
Unknown Object (File)
Wed, Nov 20, 8:40 AM
Unknown Object (File)
Wed, Nov 20, 8:40 AM
Unknown Object (File)
Wed, Nov 20, 8:40 AM
Unknown Object (File)
Wed, Nov 20, 8:39 AM
Unknown Object (File)
Wed, Nov 20, 8:39 AM
Unknown Object (File)
Mon, Nov 18, 8:39 PM
View All 58 Files
Subscribers
ashoat

Details

Reviewers
kamil
angelika
Commits
rCOMM9a1e431d3184: [lib] Show staff alerts when an operation isn't processed
Summary

Show an alert for all the cases where an operation can't be immediately processed.

https://linear.app/comm/issue/ENG-9686/some-messages-from-newly-created-chat-missing-on-secondary-device#comment-61c90aa7

Depends on D13724

Test Plan

Checked that an alert is shown after queueing operations on web in dev mode. Deleted the dev check and made sure the alert isn't shown.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Oct 16 2024, 7:05 AM
Herald added a subscriber: ashoat. · View Herald TranscriptOct 16 2024, 7:05 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 16 2024, 7:19 AM
Harbormaster failed remote builds in B32266: Diff 45222!
tomek updated this revision to Diff 45224.Oct 16 2024, 7:21 AM

Rebase

Harbormaster completed remote builds in B32268: Diff 45224.Oct 16 2024, 7:42 AM
tomek requested review of this revision.Oct 16 2024, 7:42 AM
kamil accepted this revision.Oct 17 2024, 7:32 AM

According to this comment worth adding this to encryption related errors:

We'll discuss this async and add this to this diff or I can put up another one

This revision is now accepted and ready to land.Oct 17 2024, 7:32 AM
tomek added a comment.Oct 21 2024, 8:58 AM
In D13725#384293, @kamil wrote:

According to this comment worth adding this to encryption related errors:

We'll discuss this async and add this to this diff or I can put up another one

We're going to add these as a part of https://linear.app/comm/issue/ENG-9686/some-messages-from-newly-created-chat-missing-on-secondary-device.

Closed by commit rCOMM9a1e431d3184: [lib] Show staff alerts when an operation isn't processed (authored by tomek). · Explain WhyOct 21 2024, 9:01 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM9a1e431d3184: [lib] Show staff alerts when an operation isn't processed.

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
44 lines

Diff 45222

View Options

lib/shared/dm-ops/process-dm-ops.js

Loading...