[lib] Delete users for whom identity didnt return a device list for a long time
ClosedPublic
Actions

Authored by inka on Oct 17 2024, 4:22 AM.

Details

Reviewers

tomek
kamil

Commits

rCOMMda9fc92ba039: [lib] Delete users for whom identity didnt return a device list for a long time

Summary

issue: ENG-9632
If we fail to fetch usres device list for a whole day, we can assume that this is not due to identity temporary data inconsistency. And if a user is a member of a DM, and their device list is not present on the identity, then we know for certain that they deleted their account.
There is only one catch here - if the request times out we shouldn't be deleting the user. Created ENG-9725 to address this

Test Plan

Tested that a user whose device list failed to be fetched for a long time gets deleted and they get removed from threads, users store and aux user store.
Checked that a user whose lastChecked was updated does not get removed from threads and other stores

Diff Detail

Repository

rCOMM Comm

Branch

inka/missing_peers

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Oct 17 2024, 4:22 AM

Herald added a subscriber: ashoat. · View Herald TranscriptOct 17 2024, 4:22 AM

inka added a parent revision: D13740: [lib] Reduce removePeerUsersActionType in thread reducer.Oct 17 2024, 4:22 AM

Harbormaster completed remote builds in B32287: Diff 45245.Oct 17 2024, 4:40 AM

inka requested review of this revision.Oct 17 2024, 4:40 AM

Rebase

Harbormaster completed remote builds in B32295: Diff 45257.Oct 17 2024, 6:54 AM

inka added a child revision: D13750: [lib] Handle identity timeout when fetching device lists.Oct 18 2024, 3:36 AM

tomek accepted this revision.Mon, Oct 21, 3:41 AM

tomek added inline comments.

lib/shared/dm-ops/dm-op-utils.js
178–202 ↗	(On Diff #45257)	It might be a good idea to make the dependency between `nonDeletedUsers` and `deletedUsers` explicit by creating a function.