Page MenuHomePhabricator
Differential D13761

[lib] Use getMessageForException instead of e.message in DM related code
ClosedPublic
Actions

Authored by angelika on Oct 21 2024, 1:28 PM.
Tags
None
Referenced Files
F3331738: D13761.id45303.diff
Wed, Nov 20, 9:09 PM
F3331724: D13761.id.diff
Wed, Nov 20, 9:09 PM
F3331711: D13761.diff
Wed, Nov 20, 9:09 PM
Unknown Object (File)
Mon, Nov 18, 5:01 PM
Unknown Object (File)
Sun, Nov 10, 2:08 PM
Unknown Object (File)
Fri, Nov 8, 11:07 PM
Unknown Object (File)
Thu, Nov 7, 3:32 PM
Unknown Object (File)
Wed, Nov 6, 4:07 PM
View All 44 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
tomek
ashoat
Commits
rCOMM4af551886ca0: [lib] Use getMessageForException instead of e.message in DM related code
Summary

Use getMessageForException instead of e.message in DM related code in order to avoid bugs when throwing primitives.
Depends on D13757

Test Plan
  1. Run flow checks, run the app, verify that nothing crashes.

Diff Detail

Repository
rCOMM Comm
Branch
graszka22/ENG-9729
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

Diff 45316

View Options

lib/tunnelbroker/peer-to-peer-message-handler.js

Loading...
View Options

lib/tunnelbroker/use-peer-to-peer-message-handler.js

Loading...
View Options

lib/utils/peer-to-peer-communication-utils.js

Loading...