Differential D13769

[lib] rename parentThreadInfo -> threadInfo in getCommunity
ClosedPublic
Actions

Authored by varun on Oct 22 2024, 4:12 PM.

Details

Reviewers

ashoat

Commits

rCOMMa6d3fc46c070: [lib] rename parentThreadInfo -> threadInfo in getCommunity

Summary

Depends on D13753. Follow up from D13745

old param name suggested that the function would only work for child threads in a community but the function actually returns the community for the community root thread as well

Test Plan

flow

Diff Detail

Repository

rCOMM Comm

Branch

farcaster-thread-avatars (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Oct 22 2024, 4:12 PM

Herald added a subscriber: tomek. · View Herald TranscriptOct 22 2024, 4:12 PM

varun mentioned this in D13745: [web] update ThreadAvatar component to pass farcaster channel ID to useResolvedThreadAvatar.Oct 22 2024, 4:13 PM

varun edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B32337: Diff 45326.Oct 22 2024, 4:43 PM

varun requested review of this revision.Oct 22 2024, 4:43 PM

ashoat accepted this revision.Oct 22 2024, 5:24 PM

This revision is now accepted and ready to land.Oct 22 2024, 5:24 PM

Closed by commit rCOMMa6d3fc46c070: [lib] rename parentThreadInfo -> threadInfo in getCommunity (authored by varun). · Explain WhyOct 22 2024, 9:52 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMa6d3fc46c070: [lib] rename parentThreadInfo -> threadInfo in getCommunity.

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

6 lines

Diff 45326

View Options

lib/shared/thread-utils.js

[lib] rename parentThreadInfo -> threadInfo in getCommunityClosedPublicActions