Page MenuHomePhabricator

[web] update EditThreadAvatarMenu to add farcaster option
ClosedPublic

Authored by varun on Oct 19 2024, 11:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 6:04 AM
Unknown Object (File)
Thu, Nov 21, 6:03 PM
Unknown Object (File)
Wed, Nov 20, 8:17 AM
Unknown Object (File)
Wed, Nov 20, 8:16 AM
Unknown Object (File)
Wed, Nov 20, 8:16 AM
Unknown Object (File)
Mon, Nov 11, 1:21 AM
Unknown Object (File)
Thu, Nov 7, 7:49 PM
Unknown Object (File)
Thu, Nov 7, 3:09 PM
Subscribers

Details

Summary

this lets a user set a farcaster thread avatar if the thread belongs to a community tagged with a farcaster channel

Depends on D13749

Test Plan

successfully set a farcaster avatar in community root thread and child threads. was able to unset the avatar as well.

menu icon looks the same as in the user avatar menu

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

web/avatars/edit-thread-avatar-menu.react.js
143 ↗(On Diff #45282)

one thing worth noting is that we'll display this menu item even if the thread has inherited a farcaster avatar from its parent as the default

This revision is now accepted and ready to land.Oct 20 2024, 11:44 AM