Page MenuHomePhabricator
Differential D13790

[identity] bump native min supported version and add web min supported version
ClosedPublic
Actions

Authored by varun on Oct 25 2024, 1:13 PM.
Tags
None
Referenced Files
F3359051: D13790.id45389.diff
Sun, Nov 24, 6:52 AM
Unknown Object (File)
Sat, Nov 23, 4:43 AM
Unknown Object (File)
Thu, Nov 7, 1:39 PM
Unknown Object (File)
Mon, Nov 4, 5:11 PM
Unknown Object (File)
Mon, Nov 4, 7:21 AM
Unknown Object (File)
Mon, Nov 4, 5:00 AM
Unknown Object (File)
Sat, Nov 2, 8:09 AM
Unknown Object (File)
Fri, Nov 1, 10:07 PM
View All 17 Files
Subscribers
ashoat
tomek

Details

Reviewers
will
Commits
rCOMM9644fafebfb1: [identity] bump native min supported version and add web min supported version
Summary

bump native min supported version to 401, to resolve https://linear.app/comm/issue/ENG-9421/consider-marking-mobile-versions-below-401-unsupported-by-identity

also introducing a web min supported version and setting it to 120, which is the web equivalent of 401

Test Plan

changed min supported versions on staging identity to one higher than my dev native/web versions. was logged out on both platforms with an alert/modal explaining why. was alerted that i should update when i tried to log back in. then changed min supported versions back to 401/120 and could log in again

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Oct 25 2024, 1:13 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 25 2024, 1:13 PM
varun added inline comments.Oct 25 2024, 1:16 PM
services/identity/src/grpc_services/shared.rs
23–26

https://github.com/CommE2E/comm/blob/7fa23109af4160b7995f56a2472f770469f8dc38/web/grpc/interceptor.js#L37-L43 got the platform strings from here

varun added a comment.Oct 25 2024, 1:23 PM

I didn't test on desktop platforms but we version them the same as web

Harbormaster completed remote builds in B32374: Diff 45389.Oct 25 2024, 1:30 PM
varun requested review of this revision.Oct 25 2024, 1:30 PM
will accepted this revision.Oct 25 2024, 1:33 PM
This revision is now accepted and ready to land.Oct 25 2024, 1:33 PM
Closed by commit rCOMM9644fafebfb1: [identity] bump native min supported version and add web min supported version (authored by varun). · Explain WhyOct 25 2024, 1:35 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM9644fafebfb1: [identity] bump native min supported version and add web min supported version.
bartek mentioned this in D13888: [lib] Stop shimming Blob-hosted multimedia messages.Fri, Nov 8, 1:09 AM

Revision Contents
Changeset List

PathSize
services/
identity/
src/
3 lines
grpc_services/
9 lines

Diff 45389

View Options

services/identity/src/constants.rs

Loading...
View Options

services/identity/src/grpc_services/shared.rs

Loading...