Question about the test plan:

After this patch there should be less of them

Did some of errors still appear? What's your theory for why that is?

In D13802#385659, @ashoat wrote:

Question about the test plan:

After this patch there should be less of them

Did some of errors still appear? What's your theory for why that is?

Yes, they still appeared probably because this one: https://phab.comm.dev/D13792 has not landed yet. When I was testing that one the errors also disappeared.

You can't update the commit message with arc diff. Instead, you should edit the revision on Phabricator, and then run arc amend locally to update the commit text based on what's on Phabricator. (I think this last step also gets run automatically as part of arc land.)

In D13802#386045, @ashoat wrote:

You can't update the commit message with arc diff. Instead, you should edit the revision on Phabricator, and then run arc amend locally to update the commit text based on what's on Phabricator. (I think this last step also gets run automatically as part of arc land.)

oh, ok, I wanted to do just arc amend, I thought I need to do this manually 🤦‍♀️