Page MenuHomePhabricator
Differential D13851

[keyserver] fetchThreadInfos -> fetchAccessibleThreadInfos
AbandonedPublic
Actions

Authored by varun on Oct 31 2024, 10:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 10:56 PM
Unknown Object (File)
Thu, Dec 19, 1:50 AM
Unknown Object (File)
Thu, Dec 19, 1:50 AM
Unknown Object (File)
Mon, Dec 16, 6:09 PM
Unknown Object (File)
Mon, Dec 16, 2:54 AM
Unknown Object (File)
Mon, Dec 16, 2:54 AM
Unknown Object (File)
Mon, Dec 16, 2:54 AM
Unknown Object (File)
Tue, Dec 3, 3:16 PM
View All 33 Files
Subscribers
tomek

Details

Reviewers
ashoat
Summary

simple rename so that I can introduce a new function called fetchThreadInfos that doesn't filter out threads that aren't accessible

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Oct 31 2024, 10:39 PM
Herald added a subscriber: tomek. · View Herald TranscriptOct 31 2024, 10:39 PM
varun added a child revision: D13852: [keyserver] new fetchPrivilegedThreadInfos function.Oct 31 2024, 10:42 PM
Harbormaster completed remote builds in B32503: Diff 45567.Oct 31 2024, 10:57 PM
varun requested review of this revision.Oct 31 2024, 10:57 PM
ashoat requested changes to this revision.Nov 1 2024, 8:34 AM

I think it might be confusing to people on the team that fetchThreadInfos used to mean something, but now it means something else

Can you explain your thinking around renaming the existing method instead of using a separate name for your new method?

Passing back with question

This revision now requires changes to proceed.Nov 1 2024, 8:34 AM
varun abandoned this revision.Nov 15 2024, 9:50 AM

decided not to rename. will instead call my new function fetchPrivilegedThreadInfos

Revision Contents
Changeset List

PathSize
keyserver/
src/
creators/
4 lines
4 lines
4 lines
deleters/
4 lines
fetchers/
4 lines
11 lines
responders/
4 lines
4 lines
shared/
state-sync/
6 lines
updaters/
6 lines
4 lines

Diff 45567

View Options

keyserver/src/creators/account-creator.js

Loading...
View Options

keyserver/src/creators/role-creator.js

Loading...
View Options

keyserver/src/creators/update-creator.js

Loading...
View Options

keyserver/src/deleters/role-deleters.js

Loading...
View Options

keyserver/src/fetchers/thread-fetchers.js

Loading...
View Options

keyserver/src/fetchers/thread-permission-fetchers.js

Loading...
View Options

keyserver/src/responders/redux-state-responders.js

Loading...
View Options

keyserver/src/responders/user-responders.js

Loading...
View Options

keyserver/src/shared/state-sync/threads-state-sync-spec.js

Loading...
View Options

keyserver/src/updaters/thread-updaters.js

Loading...
View Options

keyserver/src/updaters/user-subscription-updaters.js

Loading...