Page MenuHomePhabricator
Differential D13854

[keyserver] return threadInfo in fetchAllCommunityInfosWithNames
ClosedPublic
Actions

Authored by varun on Thu, Oct 31, 10:48 PM.
Tags
None
Referenced Files
F3349480: D13854.id45892.diff
Fri, Nov 22, 6:06 PM
F3349467: D13854.id45897.diff
Fri, Nov 22, 6:05 PM
Unknown Object (File)
Thu, Nov 21, 4:06 AM
Unknown Object (File)
Mon, Nov 18, 11:15 PM
Unknown Object (File)
Sun, Nov 17, 4:41 PM
Unknown Object (File)
Fri, Nov 15, 2:54 AM
Unknown Object (File)
Thu, Nov 14, 9:00 PM
Unknown Object (File)
Thu, Nov 14, 7:03 PM
View All 19 Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMM183ac09a25b3: [keyserver] return threadInfo in fetchAllCommunityInfosWithNames
Summary

Depends on D13853

we return threadInfos here so that we can populate the community directory on clients using the ThreadList component

Test Plan

tested in next diff by calling fetchAllCommunityInfosWithNames and getting a working modal with the ThreadList correctly populated

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Thu, Oct 31, 10:48 PM
Herald added a subscriber: tomek. · View Herald TranscriptThu, Oct 31, 10:48 PM
varun added a child revision: D13493: [native] scaffolding for CommunityJoinerModal.Thu, Oct 31, 10:49 PM
varun published this revision for review.Thu, Oct 31, 11:11 PM
varun planned changes to this revision.
Harbormaster completed remote builds in B32506: Diff 45570.Thu, Oct 31, 11:12 PM
ashoat requested changes to this revision.Fri, Nov 1, 8:37 AM
ashoat added inline comments.
lib/types/community-types.js
50

Should this be narrowed? It doesn't appear possible for the server to return undefined

58

I might be missing something, but this validator appears to only be used on the client. Why are you using mixedRawThreadInfoValidator?

varun updated this revision to Diff 45892.Tue, Nov 19, 9:24 PM

address feedback

varun added inline comments.Tue, Nov 19, 9:27 PM
keyserver/src/fetchers/community-fetchers.js
103 ↗(On Diff #45892)

I had to add an explicit type here because flow was confused by result being any-typed

Harbormaster completed remote builds in B32720: Diff 45892.Wed, Nov 20, 3:30 AM
ashoat accepted this revision.Wed, Nov 20, 4:15 AM
This revision is now accepted and ready to land.Wed, Nov 20, 4:15 AM
Closed by commit rCOMM183ac09a25b3: [keyserver] return threadInfo in fetchAllCommunityInfosWithNames (authored by varun). · Explain WhyWed, Nov 20, 5:20 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM183ac09a25b3: [keyserver] return threadInfo in fetchAllCommunityInfosWithNames.

Revision Contents
Changeset List

PathSize
keyserver/
src/
fetchers/
17 lines
responders/
4 lines
lib/
actions/
4 lines
types/
21 lines
4 lines
validators/
4 lines

Diff 45570

View Options

keyserver/src/fetchers/community-fetchers.js

Loading...
View Options

keyserver/src/responders/community-responders.js

Loading...
View Options

lib/actions/community-actions.js

Loading...
View Options

lib/types/community-types.js

Loading...
View Options

lib/types/redux-types.js

Loading...
View Options

lib/types/validators/community-validators.js

Loading...