Page MenuHomePhabricator

[native] Consider BottomSheetHandle size when setting snapPoints
ClosedPublic

Authored by ashoat on Mon, Nov 4, 1:53 PM.
Tags
None
Referenced Files
F3334066: D13867.id45591.diff
Thu, Nov 21, 5:56 AM
F3332970: D13867.diff
Thu, Nov 21, 3:05 AM
F3327810: D13867.id45639.diff
Wed, Nov 20, 12:34 PM
Unknown Object (File)
Tue, Nov 19, 8:46 PM
Unknown Object (File)
Sun, Nov 17, 3:44 PM
Unknown Object (File)
Thu, Nov 14, 12:09 AM
Unknown Object (File)
Wed, Nov 13, 8:56 PM
Unknown Object (File)
Wed, Nov 13, 3:05 AM
Subscribers

Details

Summary

The height of BottomSheetHandle is always the same, and we should take it into account when setting snapPoints. More context here.

Test Plan

In combination with the rest of the stack, I tested each individual use of our BottomSheet component to make sure that the bottom padding was reasonable. In most cases it was unchanged; in other cases, it was changed to be more consistent with the other BottomSheets in our codebase. In all cases, there was enough padding for the "home pill" at the bottom of the screen

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage