Details
Force the error when sending message:
0. Create DM with some user
- Comment out error swallowing in peer-list-hooks.js
- Change identity address to some random address
- Remove device lists by dispatching an action as described in the issue
- Try to send a message
- Verify that the app doesn't crash and user can retry sending the message and you can see the error nicely in the logs
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Can you add a specific message to each SendMessageError error? I realize it wasn't there before, but it might be helpful here to have some additional context
| native/chat/reaction-message-utils.js | ||
|---|---|---|
| 118–122 ↗ | (On Diff #45586) | |
| native/input/input-state-container.react.js | ||
| 593 ↗ | (On Diff #45586) | Accidentally left over |
| native/chat/reaction-message-utils.js | ||
|---|---|---|
| 118–122 ↗ | (On Diff #45586) | Looks like this type is not correct, but was not correct in the past either, see here Wondering, if we should use SendMessageError type in /lib/types/redux-types.js to catch things like this? I am talking about this three specific actions:
|
| native/chat/reaction-message-utils.js | ||
|---|---|---|
| 118–122 ↗ | (On Diff #45586) |
Good call... yeah, I think that would be best. In addition to the changes @angelika made here to lib/types/redux-types.js, I think we should update the place(s) where the error is thrown... looks to be in lib/hooks/input-state-container-hooks.js. Hopefully we can remove the any-cast there |
| lib/hooks/input-state-container-hooks.js | ||
|---|---|---|
| 255–263 ↗ | (On Diff #45644) | thanks for doing this |