[native] Fix QR code scanning on Android
ClosedPublic
Actions

Authored by angelika on Nov 5 2024, 9:17 AM.

Details

Reviewers

tomek
kamil
bartek

Commits

rCOMM429c59416e23: [native] Fix QR code scanning on Android

Summary

https://linear.app/comm/issue/ENG-9842/unable-to-scan-qr-code-on-android

Test Plan

Go to Profile -> Linked devices -> Add and try scanning qr code

Diff Detail

Repository

rCOMM Comm

Branch

graszka22/ENG-9842

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Nov 5 2024, 9:17 AM

Herald added a subscriber: ashoat. · View Herald TranscriptNov 5 2024, 9:18 AM

Great find here!! Is it possible that this fixes ENG-8780 as well? I think that one is also a permissions issue.

Harbormaster completed remote builds in B32549: Diff 45617.Nov 5 2024, 10:04 AM

angelika requested review of this revision.Nov 5 2024, 10:04 AM

Nice find!

This revision is now accepted and ready to land.Nov 6 2024, 2:53 AM

In D13880#387505, @ashoat wrote:

Great find here!! Is it possible that this fixes ENG-8780 as well? I think that one is also a permissions issue.

Unfortunately, it doesn't fix that one, it's a separate issue.

Closed by commit rCOMM429c59416e23: [native] Fix QR code scanning on Android (authored by angelika). · Explain WhyNov 6 2024, 4:28 AM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM429c59416e23: [native] Fix QR code scanning on Android.

Revision Contents
Changeset List

Path

Size

native/

android/

app/

src/

main/

java/

app/

comm/

android/

MainActivity.java

1 line

Diff 45617

View Options

native/android/app/src/main/java/app/comm/android/MainActivity.java

[native] Fix QR code scanning on AndroidClosedPublicActions