Page MenuHomePhabricator
Differential D13899

[native] Implement getInboundP2PMessagesByID query in JSI
ClosedPublic
Actions

Authored by angelika on Nov 8 2024, 7:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 3:48 AM
Unknown Object (File)
Wed, Dec 18, 9:21 PM
Unknown Object (File)
Sun, Dec 15, 9:32 AM
Unknown Object (File)
Sat, Dec 14, 10:46 AM
Unknown Object (File)
Fri, Dec 13, 11:16 PM
Unknown Object (File)
Fri, Dec 13, 11:16 PM
Unknown Object (File)
Fri, Dec 13, 11:16 PM
Unknown Object (File)
Fri, Dec 13, 11:16 PM
View All 55 Files
Subscribers
ashoat

Details

Reviewers
tomek
kamil
Commits
rCOMM829132ae786b: [native] Implement getInboundP2PMessagesByID query in JSI
Summary

https://linear.app/comm/issue/ENG-9713/mitigate-risk-of-olm-already-decrypted-or-keys-skipped

Depends on D13898

Test Plan

Test plan in the last diff in stack.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

angelika created this revision.Nov 8 2024, 7:55 AM
Herald added a subscriber: ashoat. · View Herald TranscriptNov 8 2024, 7:55 AM
angelika added a child revision: D13900: [lib] Implement getInboundP2PMessagesByID in SQLiteAPI.Nov 8 2024, 7:56 AM
Harbormaster completed remote builds in B32594: Diff 45723.Nov 8 2024, 8:20 AM
angelika requested review of this revision.Nov 8 2024, 8:20 AM
kamil accepted this revision.Nov 12 2024, 2:56 AM
kamil added inline comments.
native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
3247–3262 ↗(On Diff #45723)

can you create an util function to de-duplicate this with code here?

Something similar to e.g. parseOneTimeKeysResult

native/schema/CommCoreModuleSchema.js
213–215 ↗(On Diff #45723)

nit: I prefer to put this closer to other P2P-related methods, e.g. line 182 but up to you. If you agree this applies to .h file it this diff too

This revision is now accepted and ready to land.Nov 12 2024, 2:56 AM
angelika updated this revision to Diff 45737.Nov 12 2024, 5:26 AM

Review changes: add parseInboundingMessages and change methods order

Harbormaster failed remote builds in B32603: Diff 45737!Nov 12 2024, 5:39 AM
angelika updated this revision to Diff 45742.Nov 12 2024, 5:45 AM

Rebase

Harbormaster failed remote builds in B32608: Diff 45742!Nov 12 2024, 6:01 AM
angelika updated this revision to Diff 45752.Nov 12 2024, 7:35 AM

Run JSI codegen

Harbormaster completed remote builds in B32616: Diff 45752.Nov 12 2024, 8:00 AM
Closed by commit rCOMM829132ae786b: [native] Implement getInboundP2PMessagesByID query in JSI (authored by angelika). · Explain WhyNov 13 2024, 4:17 AM
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMM829132ae786b: [native] Implement getInboundP2PMessagesByID query in JSI.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
2 lines
73 lines
_generated/
schema/
3 lines

Diff 45742

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI.h

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...