Paths

Table of Contentst

Differential D13899

[native] Implement getInboundP2PMessagesByID query in JSI
ClosedPublic
Actions

Authored by angelika on Fri, Nov 8, 7:55 AM.

Tags

None

Referenced Files

	F3335299: D13899.id45737.diff
	Thu, Nov 21, 9:01 AM

	F3332205: D13899.id45737.diff
	Wed, Nov 20, 11:12 PM

	Unknown Object (File)
	Wed, Nov 20, 5:44 AM

	Unknown Object (File)
	Mon, Nov 18, 7:18 PM

	Unknown Object (File)
	Mon, Nov 18, 5:57 PM

	Unknown Object (File)
	Mon, Nov 18, 4:06 PM

	Unknown Object (File)
	Mon, Nov 18, 2:02 PM

	Unknown Object (File)
	Mon, Nov 18, 11:56 AM

View All 32 Files

Subscribers

Details

Reviewers

tomek
kamil

Commits

rCOMM829132ae786b: [native] Implement getInboundP2PMessagesByID query in JSI

Summary

https://linear.app/comm/issue/ENG-9713/mitigate-risk-of-olm-already-decrypted-or-keys-skipped

Depends on D13898

Test Plan

Test plan in the last diff in stack.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

angelika created this revision.Fri, Nov 8, 7:55 AM

Herald added a subscriber: ashoat. · View Herald TranscriptFri, Nov 8, 7:55 AM

angelika added a child revision: D13900: [lib] Implement getInboundP2PMessagesByID in SQLiteAPI.Fri, Nov 8, 7:56 AM

Harbormaster completed remote builds in B32594: Diff 45723.Fri, Nov 8, 8:20 AM

angelika requested review of this revision.Fri, Nov 8, 8:20 AM

kamil accepted this revision.Tue, Nov 12, 2:56 AM

kamil added inline comments.

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
3247–3262 ↗	(On Diff #45723)	can you create an util function to de-duplicate this with code here? Something similar to e.g. `parseOneTimeKeysResult`
native/schema/CommCoreModuleSchema.js
213–215 ↗	(On Diff #45723)	nit: I prefer to put this closer to other P2P-related methods, e.g. line 182 but up to you. If you agree this applies to `.h` file it this diff too

This revision is now accepted and ready to land.Tue, Nov 12, 2:56 AM

Review changes: add parseInboundingMessages and change methods order

Harbormaster failed remote builds in B32603: Diff 45737!Tue, Nov 12, 5:39 AM

Rebase

Harbormaster failed remote builds in B32608: Diff 45742!Tue, Nov 12, 6:01 AM

Run JSI codegen

Harbormaster completed remote builds in B32616: Diff 45752.Tue, Nov 12, 8:00 AM

Closed by commit rCOMM829132ae786b: [native] Implement getInboundP2PMessagesByID query in JSI (authored by angelika). · Explain WhyWed, Nov 13, 4:17 AM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM829132ae786b: [native] Implement getInboundP2PMessagesByID query in JSI.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommCoreModule.h

2 lines

CommCoreModule.cpp

73 lines

_generated/

commJSI-generated.cpp

schema/

CommCoreModuleSchema.js

3 lines

Diff 45785

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...

native/cpp/CommonCpp/_generated/commJSI.h

Loading...

native/schema/CommCoreModuleSchema.js

Loading...