[sqlite] Rename getAllOutboundP2PMessages() to getUnsentOutboundP2PMessages()
ClosedPublic
Actions

Authored by angelika on Tue, Nov 12, 12:30 PM.

Details

Reviewers

tomek
kamil

Commits

rCOMM6c66ce0a270a: [sqlite] Rename getAllOutboundP2PMessages() to getUnsentOutboundP2PMessages()

Summary

https://linear.app/comm/issue/ENG-9291/read-outbound-messages-with-status-different-that-sent

getAllOutboundP2PMessages() no longer returns all messages, but only unsent messages. As this name
may be misleading, maybe it'd be nice to rename it.

Depends on D13908

Test Plan

Run the app and send some messages on web and native.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Tue, Nov 12, 12:30 PM

Herald added a subscriber: ashoat. · View Herald TranscriptTue, Nov 12, 12:30 PM

Harbormaster completed remote builds in B32620: Diff 45756.Tue, Nov 12, 12:50 PM

angelika requested review of this revision.Tue, Nov 12, 12:50 PM

kamil accepted this revision.Wed, Nov 13, 2:59 AM

This revision is now accepted and ready to land.Wed, Nov 13, 2:59 AM

Rebase

Harbormaster completed remote builds in B32645: Diff 45789.Wed, Nov 13, 4:42 AM

Fix line order

Harbormaster completed remote builds in B32646: Diff 45790.Wed, Nov 13, 6:02 AM

Closed by commit rCOMM6c66ce0a270a: [sqlite] Rename getAllOutboundP2PMessages() to getUnsentOutboundP2PMessages() (authored by angelika). · Explain WhyWed, Nov 13, 6:10 AM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM6c66ce0a270a: [sqlite] Rename getAllOutboundP2PMessages() to getUnsentOutboundP2PMessages().

Revision Contents
Changeset List

Path

Size

lib/

tunnelbroker/

peer-to-peer-context.js

2 lines

types/

sqlite-types.js

2 lines

utils/

__mocks__/

config.js

2 lines

native/

cpp/

CommonCpp/

DatabaseManagers/

DatabaseQueryExecutor.h

3 lines

SQLiteQueryExecutor.h

2 lines

SQLiteQueryExecutor.cpp

2 lines

NativeModules/

CommCoreModule.h

2 lines

CommCoreModule.cpp

6 lines

_generated/

commJSI-generated.cpp

commJSI.h

database/

sqlite-api.js

2 lines

schema/

CommCoreModuleSchema.js

2 lines

web/

cpp/

SQLiteQueryExecutorBindings.cpp

4 lines

database/

sqlite-api.js

2 lines

shared-worker/

_generated/

comm_query_executor.wasm

queries/

outbound-p2p-message-queries.test.js

14 lines

types/

sqlite-query-executor.js

2 lines

worker/

shared-worker.js

2 lines

Diff 45789

View Options

lib/tunnelbroker/peer-to-peer-context.js

View Options

lib/types/sqlite-types.js

View Options

lib/utils/mocks/config.js

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

View Options

native/cpp/CommonCpp/_generated/commJSI.h

View Options

native/database/sqlite-api.js

View Options

native/schema/CommCoreModuleSchema.js

View Options

web/cpp/SQLiteQueryExecutorBindings.cpp

View Options

web/database/sqlite-api.js

View Options

web/shared-worker/_generated/comm_query_executor.wasm

View Options

web/shared-worker/queries/outbound-p2p-message-queries.test.js

View Options

web/shared-worker/types/sqlite-query-executor.js

View Options

web/shared-worker/worker/shared-worker.js

[sqlite] Rename getAllOutboundP2PMessages() to getUnsentOutboundP2PMessages()ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45789

lib/tunnelbroker/peer-to-peer-context.js

lib/types/sqlite-types.js

lib/utils/__mocks__/config.js

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

native/cpp/CommonCpp/_generated/commJSI.h

native/database/sqlite-api.js

native/schema/CommCoreModuleSchema.js

web/cpp/SQLiteQueryExecutorBindings.cpp

web/database/sqlite-api.js

web/shared-worker/_generated/comm_query_executor.wasm

web/shared-worker/queries/outbound-p2p-message-queries.test.js

web/shared-worker/types/sqlite-query-executor.js

web/shared-worker/worker/shared-worker.js

[sqlite] Rename getAllOutboundP2PMessages() to getUnsentOutboundP2PMessages()
ClosedPublic
Actions

Revision Contents
Changeset List

lib/utils/mocks/config.js