Page MenuHomePhabricator
Differential D13909

[sqlite] Rename getAllOutboundP2PMessages() to getUnsentOutboundP2PMessages()
ClosedPublic
Actions

Authored by angelika on Tue, Nov 12, 12:30 PM.
Tags
None
Referenced Files
F3333811: D13909.diff
Thu, Nov 21, 5:17 AM
F3332262: D13909.id45794.diff
Wed, Nov 20, 11:21 PM
F3331477: D13909.id45792.diff
Wed, Nov 20, 8:38 PM
Unknown Object (File)
Wed, Nov 20, 3:28 PM
Unknown Object (File)
Wed, Nov 20, 4:38 AM
Unknown Object (File)
Wed, Nov 20, 2:24 AM
Unknown Object (File)
Tue, Nov 19, 11:16 PM
Unknown Object (File)
Tue, Nov 19, 8:12 AM
View All 14 Files
Subscribers
ashoat

Details

Reviewers
tomek
kamil
Commits
rCOMM6c66ce0a270a: [sqlite] Rename getAllOutboundP2PMessages() to getUnsentOutboundP2PMessages()
Summary

https://linear.app/comm/issue/ENG-9291/read-outbound-messages-with-status-different-that-sent

getAllOutboundP2PMessages() no longer returns all messages, but only unsent messages. As this name
may be misleading, maybe it'd be nice to rename it.

Depends on D13908

Test Plan

Run the app and send some messages on web and native.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
tunnelbroker/
2 lines
types/
2 lines
utils/
__mocks__/
2 lines
native/
cpp/
CommonCpp/
DatabaseManagers/
3 lines
2 lines
2 lines
NativeModules/
6 lines
6 lines
_generated/
database/
2 lines
schema/
2 lines
web/
cpp/
4 lines
database/
2 lines
shared-worker/
_generated/
queries/
14 lines
types/
2 lines
worker/
2 lines

Diff 45792

View Options

lib/tunnelbroker/peer-to-peer-context.js

Loading...
View Options

lib/types/sqlite-types.js

Loading...
View Options

lib/utils/__mocks__/config.js

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI.h

Loading...
View Options

native/database/sqlite-api.js

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...
View Options

web/cpp/SQLiteQueryExecutorBindings.cpp

Loading...
View Options

web/database/sqlite-api.js

Loading...
View Options

web/shared-worker/_generated/comm_query_executor.wasm

Loading...
View Options

web/shared-worker/queries/outbound-p2p-message-queries.test.js

Loading...
View Options

web/shared-worker/types/sqlite-query-executor.js

Loading...
View Options

web/shared-worker/worker/shared-worker.js

Loading...