Differential D13938

[lib] Use useUsersSupportThickThreads() (with auxUserInfos) in useUpdateRelationships()
AcceptedPublic
Actions

Authored by angelika on Thu, Nov 14, 12:49 PM.

Tags

None

Referenced Files

	F3361972: D13938.id45829.diff
	Sun, Nov 24, 8:43 PM

	F3360883: D13938.id.diff
	Sun, Nov 24, 2:41 PM

	Unknown Object (File)
	Sat, Nov 23, 4:44 AM

	Unknown Object (File)
	Fri, Nov 22, 6:12 PM

	Unknown Object (File)
	Fri, Nov 22, 8:13 AM

	Unknown Object (File)
	Thu, Nov 21, 5:38 PM

	Unknown Object (File)
	Thu, Nov 21, 2:41 AM

	Unknown Object (File)
	Mon, Nov 18, 9:53 PM

View All 19 Files

Subscribers

Details

Reviewers

kamil
tomek

Summary

https://linear.app/comm/issue/ENG-9509/accepting-a-friend-request-on-web-creates-thin-thread

Test Plan

Mobile user makes a new thick thread with web user (with new message button)
Mobile user sends friend request
Throw some error in fetchUserIdentitiesPromise() so that finding user indentity always fails
Web user accepts the request
Before a new thin thread was created. Now no new threads are created, users are friends, because user identity is found in auxUserInfo.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Thu, Nov 14, 12:49 PM

Herald added a subscriber: ashoat. · View Herald TranscriptThu, Nov 14, 12:49 PM

angelika added a child revision: D13939: [lib] Consider thread infos in useUsersSupportThickThreads().Thu, Nov 14, 12:50 PM

ashoat mentioned this in D13940: [lib] Don't swallow errors in getUserIdentities() call.Thu, Nov 14, 1:10 PM

ashoat mentioned this in D13939: [lib] Consider thread infos in useUsersSupportThickThreads().Thu, Nov 14, 1:33 PM

Harbormaster completed remote builds in B32670: Diff 45829.Thu, Nov 14, 2:06 PM

angelika requested review of this revision.Thu, Nov 14, 2:06 PM

kamil accepted this revision.Mon, Nov 18, 1:57 AM

This revision is now accepted and ready to land.Mon, Nov 18, 1:57 AM

Rebase

angelika added a child revision: D14022: [lib] Check if device list exists instead of using userHasDeviceList() in useUsersSupportThickThreads().Fri, Nov 22, 1:17 PM

Harbormaster completed remote builds in B32786: Diff 45973.Fri, Nov 22, 1:29 PM

Revision Contents
Changeset List

Path

Size

lib/

hooks/

relationship-hooks.js

11 lines

Diff 45829

lib/hooks/relationship-hooks.js

Loading...