[keyserver] Log on keyserver when INITIAL_NOTIFICATIONS_ENCRYPTED_MESSAGE is sent to the client
ClosedPublic
Actions

Authored by angelika on Mon, Nov 18, 5:29 AM.

Details

Reviewers

kamil
tomek

Commits

rCOMM287b768e8ff4: [keyserver] Log on keyserver when INITIAL_NOTIFICATIONS_ENCRYPTED_MESSAGE is…

Summary

https://linear.app/comm/issue/ENG-9932/log-on-keyserver-when-initial-notifications-encrypted-message-is-sent

Test Plan

Flow and put the log somewhere else and check if it logs (I don't know how to trigger olmNotificationsSessionMissing)

Diff Detail

Repository

rCOMM Comm

Branch

graszka22/ENG-9932

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Mon, Nov 18, 5:29 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMon, Nov 18, 5:29 AM

Harbormaster completed remote builds in B32692: Diff 45858.Mon, Nov 18, 5:50 AM

angelika requested review of this revision.Mon, Nov 18, 5:50 AM

Just wondering, what do you think of this style?

const { userID, cookieID, sessionID } = viewer;
const data = { userID, cookieID, sessionID };
console.log(
  'Sending INITIAL_NOTIFICATIONS_ENCRYPTED_MESSAGE ' +
    JSON.stringify(data),
);

Could work both here and in D13952.

In D13951#389437, @ashoat wrote:
Just wondering, what do you think of this style?
const { userID, cookieID, sessionID } = viewer;
const data = { userID, cookieID, sessionID };
console.log(
  'Sending INITIAL_NOTIFICATIONS_ENCRYPTED_MESSAGE ' +
    JSON.stringify(data),
);
Could work both here and in D13952.