Differential D14022

[lib] Check if device list exists instead of using userHasDeviceList() in useUsersSupportThickThreads()
AcceptedPublic
Actions

Authored by angelika on Fri, Nov 22, 1:17 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 22, 4:07 PM

	Unknown Object (File)
	Fri, Nov 22, 4:07 PM

	Unknown Object (File)
	Fri, Nov 22, 4:07 PM

Subscribers

Details

Reviewers

kamil
tomek

Summary

https://linear.app/comm/issue/ENG-9509/accepting-a-friend-request-on-web-creates-thin-thread

Related discussion: https://phab.comm.dev/D13939#389720

Depends on D13938

Test Plan

Send and accept a friend request. Verify that a thick thread is created.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Fri, Nov 22, 1:17 PM

Herald added a subscriber: ashoat. · View Herald TranscriptFri, Nov 22, 1:17 PM

angelika added a child revision: D14023: [lib] Don't created thin thread if call to identity server failed when adding friends.Fri, Nov 22, 1:23 PM

angelika mentioned this in D13939: [lib] Consider thread infos in useUsersSupportThickThreads().Fri, Nov 22, 1:24 PM

Harbormaster completed remote builds in B32787: Diff 45974.Fri, Nov 22, 1:33 PM

angelika requested review of this revision.Fri, Nov 22, 1:33 PM

kamil accepted this revision.Mon, Nov 25, 5:11 AM

This revision is now accepted and ready to land.Mon, Nov 25, 5:11 AM

Revision Contents
Changeset List

Path

Size

lib/

hooks/

user-identities-hooks.js

3 lines

Diff 45974

lib/hooks/user-identities-hooks.js

Loading...