[native] remove comment from `BackupHandler`
ClosedPublic
Actions

Authored by kamil on Dec 3 2024, 6:33 AM.

Details

Reviewers

bartek
tomek

Commits

rCOMM066e576587e0: [native] remove comment from `BackupHandler`

Summary

I accidentally landed D14060 with a leftover, comment I added for myself when developing.

Test Plan

N/A

Diff Detail

Repository

rCOMM Comm

Branch

updates

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Dec 3 2024, 6:33 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptDec 3 2024, 6:33 AM

kamil published this revision for review.Dec 3 2024, 6:34 AM

kamil retitled this revision from [native] remove comment from to [native] remove comment from `BackupHandler`.

Harbormaster completed remote builds in B32923: Diff 46206.Dec 3 2024, 6:51 AM

bartek accepted this revision.Dec 3 2024, 9:47 AM

This revision is now accepted and ready to land.Dec 3 2024, 9:47 AM

Closed by commit rCOMM066e576587e0: [native] remove comment from `BackupHandler` (authored by kamil). · Explain WhyDec 4 2024, 4:38 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM066e576587e0: [native] remove comment from `BackupHandler`.

Revision Contents
Changeset List

Path

Size

native/

backup/

backup-handler.js

1 line

Diff 46206

View Options

native/backup/backup-handler.js

Show All 12 Lines
import {		import {
createAsyncMigrate,		createAsyncMigrate,
type StorageMigrationFunction,		type StorageMigrationFunction,
} from 'lib/shared/create-async-migrate.js';		} from 'lib/shared/create-async-migrate.js';
import type {		import type {
KeyserverInfo,		KeyserverInfo,
KeyserverStore,		KeyserverStore,
} from 'lib/types/keyserver-types.js';		} from 'lib/types/keyserver-types.js';
		import { cookieTypes } from 'lib/types/session-types.js';
import {		import {
defaultConnectionInfo,		defaultConnectionInfo,
type ConnectionInfo,		type ConnectionInfo,
} from 'lib/types/socket-types.js';		} from 'lib/types/socket-types.js';
		import { parseCookies } from 'lib/utils/cookie-utils.js';
import { isDev } from 'lib/utils/dev-utils.js';		import { isDev } from 'lib/utils/dev-utils.js';
import {		import {
generateIDSchemaMigrationOpsForDrafts,		generateIDSchemaMigrationOpsForDrafts,
convertDraftStoreToNewIDSchema,		convertDraftStoreToNewIDSchema,
} from 'lib/utils/migration-utils.js';		} from 'lib/utils/migration-utils.js';
import { ashoatKeyserverID } from 'lib/utils/validation-utils.js';		import { ashoatKeyserverID } from 'lib/utils/validation-utils.js';

import commReduxStorageEngine from './comm-redux-storage-engine.js';		import commReduxStorageEngine from './comm-redux-storage-engine.js';
▲ Show 20 Lines • Show All 92 Lines • ▼ Show 20 Lines	[5]: async state => {

await databaseModule.schedule({		await databaseModule.schedule({
type: workerRequestMessageTypes.PROCESS_STORE_OPERATIONS,		type: workerRequestMessageTypes.PROCESS_STORE_OPERATIONS,
storeOperations: { draftStoreOperations },		storeOperations: { draftStoreOperations },
});		});

return state;		return state;
},		},
		[6]: async (state: AppState): Promise<AppState> => {
		const params = parseCookies(document.cookie);
		let cookie = null;
		if (params[cookieTypes.USER]) {
		cookie = `${cookieTypes.USER}=${params[cookieTypes.USER]}`;
		} else if (params[cookieTypes.ANONYMOUS]) {
		cookie = `${cookieTypes.ANONYMOUS}=${params[cookieTypes.ANONYMOUS]}`;
		}

		return {
		...state,
		keyserverStore: {
		...state.keyserverStore,
		keyserverInfos: {
		...state.keyserverStore.keyserverInfos,
		[ashoatKeyserverID]: {
		...state.keyserverStore.keyserverInfos[ashoatKeyserverID],
		cookie,
		},
		},
		},
		};
		},
};		};

const persistWhitelist = [		const persistWhitelist = [
'enabledApps',		'enabledApps',
'deviceID',		'deviceID',
'cryptoStore',		'cryptoStore',
'notifPermissionAlertInfo',		'notifPermissionAlertInfo',
'commServicesAccessToken',		'commServicesAccessToken',
▲ Show 20 Lines • Show All 96 Lines • ▼ Show 20 Lines	const persistConfig: PersistConfig = {
whitelist: isSQLiteSupported()		whitelist: isSQLiteSupported()
? persistWhitelist		? persistWhitelist
: [...persistWhitelist, 'draftStore'],		: [...persistWhitelist, 'draftStore'],
migrate: (createAsyncMigrate(		migrate: (createAsyncMigrate(
migrations,		migrations,
{ debug: isDev },		{ debug: isDev },
migrateStorageToSQLite,		migrateStorageToSQLite,
): any),		): any),
version: 5,		version: 6,
transforms: [keyserverStoreTransform],		transforms: [keyserverStoreTransform],
};		};

export { persistConfig };		export { persistConfig };

[native] remove comment from `BackupHandler`ClosedPublicActions