Page MenuHomePhabricator
Differential D14079

[identity] fix `lastPrimarySignature` attribute
ClosedPublic
Actions

Authored by kamil on Thu, Dec 5, 3:59 AM.
Tags
None
Referenced Files
F3504978: D14079.id46215.diff
Fri, Dec 20, 11:43 AM
F3504943: D14079.id46229.diff
Fri, Dec 20, 11:25 AM
F3503736: D14079.diff
Fri, Dec 20, 6:22 AM
Unknown Object (File)
Wed, Dec 18, 5:00 AM
Unknown Object (File)
Sun, Dec 15, 4:42 AM
Unknown Object (File)
Sun, Dec 15, 3:46 AM
Unknown Object (File)
Sun, Dec 15, 2:53 AM
Unknown Object (File)
Fri, Dec 13, 12:06 AM
View All 13 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Commits
rCOMM57275f883c1d: [identity] fix `lastPrimarySignature` attribute
Summary

While testing restore flow, I discovered device list validation on other clients is not passing, it's because we don't store lastPrimarySignature in DDB correctly.

Test Plan

N/A, just carefully reading code - I am going to test this with actual restore after deploying on staging

Diff Detail

Repository
rCOMM Comm
Branch
restore
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Thu, Dec 5, 3:59 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptThu, Dec 5, 3:59 AM
kamil published this revision for review.Thu, Dec 5, 4:01 AM
Harbormaster completed remote builds in B32931: Diff 46215.Thu, Dec 5, 4:16 AM
kamil added a child revision: D14080: [lib] refactor `useClientBackup` to not use user identifier from the store.Thu, Dec 5, 4:24 AM
kamil mentioned this in D14083: [native] implement hook for restore.Thu, Dec 5, 4:46 AM
bartek accepted this revision.Fri, Dec 6, 1:44 AM
This revision is now accepted and ready to land.Fri, Dec 6, 1:44 AM
Closed by commit rCOMM57275f883c1d: [identity] fix `lastPrimarySignature` attribute (authored by kamil). · Explain WhyFri, Dec 6, 2:34 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM57275f883c1d: [identity] fix `lastPrimarySignature` attribute.
kamil mentioned this in D14089: [terraform] identity 0.47 staging deployment.Fri, Dec 6, 2:49 AM
kamil mentioned this in rCOMM115a3a39c385: [terraform] identity 0.47 staging deployment.Fri, Dec 6, 3:30 AM
ashoat added a comment.Sat, Dec 7, 12:49 PM

How serious is this issue? Wondering what the product impact was, if any

kamil added a comment.Mon, Dec 9, 1:34 AM
In D14079#392786, @ashoat wrote:

How serious is this issue? Wondering what the product impact was, if any

I think there wasn't any product impact, the first time we used this was during restore protocol, and I added it later in this stack (D14083), I don't think any existing logic depends on this, but perhaps @bartek has a better view on this.

bartek added a comment.Mon, Dec 9, 1:42 AM
In D14079#392809, @kamil wrote:
In D14079#392786, @ashoat wrote:

How serious is this issue? Wondering what the product impact was, if any

I think there wasn't any product impact, the first time we used this was during restore protocol, and I added it later in this stack (D14083), I don't think any existing logic depends on this, but perhaps @bartek has a better view on this.

There was no impact, this signature wasn't used anywhere before D14083

ashoat added a comment.Mon, Dec 9, 6:57 AM

Thanks for explaning :)

kamil mentioned this in rCOMM6e8a60ade6ed: [native] implement hook for restore.Wed, Dec 11, 5:39 AM

Revision Contents
Changeset List

PathSize
services/
identity/
src/
database/
2 lines

Diff 46215

View Options

services/identity/src/database/device_list.rs

Loading...