Page MenuHomePhabricator
Differential D14081

[lib] add Identity Restore action type
ClosedPublic
Actions

Authored by kamil on Thu, Dec 5, 4:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 1:00 AM
Unknown Object (File)
Wed, Dec 18, 12:59 PM
Unknown Object (File)
Mon, Dec 16, 6:06 AM
Unknown Object (File)
Sun, Dec 15, 10:29 PM
Unknown Object (File)
Sun, Dec 15, 4:19 AM
Unknown Object (File)
Sun, Dec 15, 3:58 AM
Unknown Object (File)
Thu, Dec 12, 10:56 AM
Unknown Object (File)
Thu, Dec 12, 6:14 AM
View All 11 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
varun
Commits
rCOMM3418cc2626ad: [lib] add Identity Restore action type
Summary

ENG-8195.

Action type to restore, similar to other Identity-auth actions.

I went through all places where identityLogInActionTypes and identityRegisterActionTypes are reduced to make sure identityRestoreActionTypes is handled in a similar way

Depends on D14080

Test Plan

Flow, logic tested later in the stack

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Thu, Dec 5, 4:32 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptThu, Dec 5, 4:32 AM
kamil added a child revision: D14082: [native] implement Restore protocol for Signed Device List.Thu, Dec 5, 4:39 AM
Harbormaster completed remote builds in B32933: Diff 46217.Thu, Dec 5, 4:49 AM
kamil published this revision for review.Fri, Dec 6, 1:43 AM
kamil added inline comments.
lib/actions/user-actions.js
1478–1482 ↗(On Diff #46217)

Not sure if we should use IDENTITY_ prefix as this is not only Identity call but a lot more (see next diff)

bartek accepted this revision.Fri, Dec 6, 2:30 AM
bartek added inline comments.
lib/actions/user-actions.js
1478–1482 ↗(On Diff #46217)

I'd call this RESTORE_USER_ - it keeps parity with the RPC name and might be more accurate

This revision is now accepted and ready to land.Fri, Dec 6, 2:30 AM
kamil updated this revision to Diff 46309.Wed, Dec 11, 5:00 AM

rename to RESTORE_USER_

Harbormaster completed remote builds in B32995: Diff 46309.Wed, Dec 11, 5:17 AM
Closed by commit rCOMM3418cc2626ad: [lib] add Identity Restore action type (authored by kamil). · Explain WhyWed, Dec 11, 5:39 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM3418cc2626ad: [lib] add Identity Restore action type.

Revision Contents
Changeset List

PathSize
lib/
actions/
7 lines
reducers/
2 lines
2 lines
2 lines
types/
16 lines
web/
redux/
2 lines

Diff 46314

View Options

lib/actions/user-actions.js

Loading...
View Options

lib/reducers/keyserver-reducer.js

Loading...
View Options

lib/reducers/nav-reducer.js

Loading...
View Options

lib/reducers/user-reducer.js

Loading...
View Options

lib/types/redux-types.js

Loading...
View Options

web/redux/services-access-token-reducer.js

Loading...