Page MenuHomePhabricator
Differential D14145

[keyserver][script] get IDs for community names
ClosedPublic
Actions

Authored by varun on Wed, Dec 11, 9:23 PM.
Tags
None
Referenced Files
F3635112: D14145.id46391.diff
Fri, Jan 3, 11:08 AM
F3631896: D14145.id46391.diff
Fri, Jan 3, 4:50 AM
Unknown Object (File)
Sun, Dec 29, 3:29 PM
Unknown Object (File)
Fri, Dec 27, 3:34 PM
Unknown Object (File)
Thu, Dec 26, 2:02 AM
Unknown Object (File)
Wed, Dec 25, 9:56 PM
Unknown Object (File)
Wed, Dec 25, 8:32 PM
Unknown Object (File)
Wed, Dec 25, 10:55 AM
View All 23 Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMM459ec0313932: [keyserver][script] get IDs for community names
Summary

we want to harcode a list of crypto community IDs so that we can display the associated communities in a tab for crypto users. i have a list of crypto community names, and need to turn this into a list of IDs

https://linear.app/comm/issue/ENG-9953/get-list-of-crypto-communities-from-ashoat-and-rahul

Test Plan

ran this locally with a couple community names and got back the corresponding IDs

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Wed, Dec 11, 9:23 PM
Herald added a subscriber: tomek. · View Herald TranscriptWed, Dec 11, 9:23 PM
varun mentioned this in D13996: [native] community joiner modal.Wed, Dec 11, 9:28 PM
Harbormaster completed remote builds in B33053: Diff 46371.Wed, Dec 11, 9:40 PM
varun requested review of this revision.Wed, Dec 11, 9:40 PM
varun edited the summary of this revision. (Show Details)Thu, Dec 12, 7:56 AM
ashoat requested changes to this revision.Thu, Dec 12, 11:06 AM

Passing back with some questions

keyserver/src/scripts/get-community-ids.js
18

What happens if a given community name is used by multiple communities? I think we have at least one case of this already for "Memes"

One way to disambiguate is to only look for the communities that have an associated Farcaster channel

29

Will you provide the list? Wondering why it's not in the file already

30

How do we know if we failed to fetch an ID for a given community? Do you plan to manually comb through and let me know which (if any) are missing?

This revision now requires changes to proceed.Thu, Dec 12, 11:06 AM
varun updated this revision to Diff 46391.Thu, Dec 12, 12:18 PM

address feedback

keyserver/src/scripts/get-community-ids.js
29

Oh, I shared it in the linear issue: https://linear.app/comm/issue/ENG-9953/get-list-of-crypto-communities-from-ashoat-and-rahul#comment-2fa1b5a3

I didn't hardcode it in the script so that it can be more general purpose

ashoat accepted this revision.Thu, Dec 12, 12:26 PM
This revision is now accepted and ready to land.Thu, Dec 12, 12:26 PM
This revision was landed with ongoing or failed builds.Thu, Dec 12, 12:27 PM
Closed by commit rCOMM459ec0313932: [keyserver][script] get IDs for community names (authored by varun). · Explain Why
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM459ec0313932: [keyserver][script] get IDs for community names.
Harbormaster completed remote builds in B33070: Diff 46391.Thu, Dec 12, 12:39 PM

Revision Contents
Changeset List

PathSize
keyserver/
src/
scripts/
34 lines

Diff 46371

View Options

keyserver/src/scripts/get-community-ids.js

Loading...